ports/161871: [patch] multimedia/mjpegtools plist incorrect with QUICKTIME=true

[Edward.Sanford.Sutton at FreeBSD.org]

>Number:         161871
>Category:       ports
>Synopsis:       [patch] multimedia/mjpegtools plist incorrect with QUICKTIME=true
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 21 11:10:11 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Edward Sanford Sutton, III
>Release:        8.2-STABLE #0: Tue Oct 11 01:30:25 MST 2011
>Organization:
>Environment:
FreeBSD darkstar.l.net 8.2-STABLE FreeBSD 8.2-STABLE #0: Tue Oct 11 01:30:25 MST 2011     mirror176 at darkstar.l.net:/usr/obj/usr/src/sys/MYKERNEL8  amd64
>Description:
  multimedia/mjpegtools installs bin/qttoy4m and bin/y4mtoqt when built with WITH_QUICKTIME defined. They are never included in pkg-plist. The attached patch adds them to pkg-plist only when the option is checked.
  Should PORTREVISION be increased when files were previously left behind? Should it be increased in the case of an update that removes entries from a pkg-plist that point to a file that is not included? Is it ever okay to set PORTREVISION in the .if test (maybe with a comment by the main one at the start of the file) so only those impacted by the change will spend time on the rebuild?
  I did not follow the PLIST_SUB convention used elsewhere in the file of ":=" and instead used the plain "=" that I have seen with other ports and in the porter's handbook. A change of := looks like it needs the : listed in pkg-plist variables too if it is changed to that.
>How-To-Repeat:
install multimedia/mjpegtools with QUICKTIME checked at config screen; packaging and uninstalls will leave behind two files.
>Fix:


Patch attached with submission follows:

diff -ruN mjpegtools.orig/Makefile mjpegtools/Makefile
--- mjpegtools.orig/Makefile	2011-10-04 10:53:36.427675000 -0700
+++ mjpegtools/Makefile	2011-10-21 03:23:41.239595524 -0700
@@ -96,9 +96,11 @@
 .endif # DV
 
 .if defined(WITH_QUICKTIME)
+PLIST_SUB+=	QUICKTIME=""
 LIB_DEPENDS+=	quicktime.0:${PORTSDIR}/multimedia/libquicktime
 CONFIGURE_ARGS+=--with-libquicktime
 .else
+PLIST_SUB+=	QUICKTIME="@comment "
 CONFIGURE_ARGS+=--without-libquicktime
 .endif # QUICKTIME
 
diff -ruN mjpegtools.orig/pkg-plist mjpegtools/pkg-plist
--- mjpegtools.orig/pkg-plist	2011-06-05 21:31:52.000000000 -0700
+++ mjpegtools/pkg-plist	2011-10-21 01:57:36.046799879 -0700
@@ -22,6 +22,7 @@
 %%PNG:%%bin/png2yuv
 bin/pnmtoy4m
 bin/ppmtoy4m
+%%QUICKTIME%%bin/qttoy4m
 bin/transist.flt
 bin/y4mblack
 bin/y4mcolorbars
@@ -34,6 +35,7 @@
 bin/y4mstabilizer
 bin/y4mtopnm
 bin/y4mtoppm
+%%QUICKTIME%%bin/y4mtoqt
 bin/y4mtoyuv
 bin/y4munsharp
 bin/ypipe


>Release-Note:
>Audit-Trail:
>Unformatted: