ports/139872: [PATCH] ports-mgmt/porttools: improve port's directory name heuristic and handle added/deleted files in CVS mode

Johannes 5 Joemann joemann at beefree.free.de
Tue Nov 29 22:52:41 UTC 2011


On Sun, 30 Oct 2011 20:10:13 GMT, crees at FreeBSD.org wrote:
> Johannes, would you like to become maintainer for porttools?

Thank you very much for considering this ... OK, I'll try to fill the
gap until someone experienced in shell scripting und port PR submitting
shows up to take maintainership.

> You could approve these patches yourself if you're happy to answer
> for them!

Approx. 17000 PRs have been submitted with porttools (>= 0.16) until
now, only three of them by myself. Therefore, although the tests I did
with the patched version of porttools were fine, I'd appreciate if
submitters / maintainers / committers with more experience would test
and/or review and/or improve my patches. But of course I'll answer for
the attached patches, which are an updated and improved version of
those above (October 2009). OK, here we go:

}Synopsis:	[PATCH] ports-mgmt/porttools: improve port's directory name heuristic, add CVSauto mode, take maintainership
}Release:	FreeBSD 8.2-STABLE i386
}Environment:
System: FreeBSD xxx.free.de 8.2-STABLE FreeBSD 8.2-STABLE #0: Fri Sep 16 18:59:44 CEST 2011
}Description:
- Improve the heuristic for finding the port's directory name:
  - If applicable, use CVS/Repository as the source of the port's
    directory name,
  - else try to fall back to the basename of the working directory
    if the PORTNAME heuristic fails.
  - The patches below also fix
    <http://sourceforge.net/support/tracker.php?aid=1969774>.
- Add CVSauto as a new diff mode:
  - Handle added/deleted files without having to cvs add/delete them.
  - Works with :pserver:anoncvs at anoncvs.fr.freebsd.org.
  - When submitting you're asked to use "port submit -L" if files are
    added or deleted, because that's FATAL for portlint.
- Don't use the full path of the working directory in diffs.
- Include a port's PORTEPOCH in update mode in the generated PR.
- To aid in debugging porttools include this information in the PR:
  - porttools' PORTREVISION and PORTEPOCH (if defined),
  - submit and diff mode used by the submitter.
- Bump PORTREVISION.
- Take maintainership.

Added file(s):
- files/patch-Makefile
- files/patch-cmd_diff.in
- files/patch-port.1
- files/patch-porttools.5
- files/patch-util_diff.in

Generated with FreeBSD Port Tools 0.99_3 (mode: change, diff: CVSauto)
}How-To-Repeat:
The behavior of :pserver:anoncvs at anoncvs.fr.FreeBSD.org is still the
same as in the How-To-Repeat section of my previous mail (Sun, 25 Oct
2009 23:17:05 +0100).
}Fix:
porttools-0.99_3.patch is attached. Apply it to the current version of
ports-mgmt/porttools (Makefile 1.28).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: porttools-0.99_3.patch
Type: text/x-diff
Size: 16798 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/attachments/20111129/4aef31dd/attachment.patch>


More information about the freebsd-ports-bugs mailing list