ports/157398: open-vm-tools is broken on FreeBSD 8.2 amd64

[Ismail YENIGUL]

>Number:         157398
>Category:       ports
>Synopsis:       open-vm-tools is broken on FreeBSD 8.2 amd64
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 29 17:00:17 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Ismail YENIGUL
>Release:        FreeBSD 8.2
>Organization:
SurGATE Labs
>Environment:
FreeBSD devel.myserver.com 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011     root at mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
I got the following error during the configuration stage of the port.

1.cc1: warnings being treated as errors
2. Unknown architecture.
3. make install command install vmware-tools to under /etc directory.

The solutions:

Error 1: I disabled -Werror flag from configure and configure.in
Error 2: I added the following lines to configure.ac. The current patch add these lines in configure only.

+   amd64)
+      userSpaceBitness="64"
+      ;;


Error 3: I apllied to the following patch to scripts/Makefile.am(current patch changes only scripts/Makefile)

--- scripts/Makefile.am.orig    2011-05-29 17:46:51.000000000 +0300
+++ scripts/Makefile.am 2011-05-29 17:47:00.000000000 +0300
@@ -3,7 +3,7 @@
 defaultscripts += suspend-vm-default
 defaultscripts += resume-vm-default
 
-confdir = /etc/vmware-tools
+confdir = ${prefix}/share/vmware-tools
 
 conf_SCRIPTS = ./common/vm-support
 conf_SCRIPTS += ./common/statechange.subr

>How-To-Repeat:
cd /usr/ports/emulators/open-vm-tools
make install

>Fix:
Here is the patch:

diff -ruN open-vm-tools.orig/files/patch-arch open-vm-tools/files/patch-arch
--- open-vm-tools.orig/files/patch-arch 2010-01-02 18:29:44.000000000 +0200
+++ open-vm-tools/files/patch-arch      2011-05-29 18:05:39.000000000 +0300
@@ -1,6 +1,6 @@
---- configure.orig     2008-03-28 10:36:13.000000000 +0100
-+++ configure  2008-03-28 10:36:45.000000000 +0100
-@@ -2259,6 +2259,9 @@
+--- configure.orig     2010-10-19 23:20:02.000000000 +0300
++++ configure  2011-05-29 17:17:13.000000000 +0300
+@@ -2925,6 +2925,9 @@
     x86_64)
        userSpaceBitness="64"
        ;;
@@ -8,5 +8,35 @@
 +      userSpaceBitness="64"
 +      ;;
     *)
-       { { echo "$as_me:$LINENO: error: Unknown architecture." >&5
- echo "$as_me: error: Unknown architecture." >&2;}
+       as_fn_error "Unknown architecture." "$LINENO" 5
+       ;;
+@@ -22414,7 +22417,7 @@
+ 
+ ### General flags / actions
+ CFLAGS="$CFLAGS -Wall"
+-CFLAGS="$CFLAGS -Werror"
++#CFLAGS="$CFLAGS -Werror"
+ 
+ # -Wno-unknown-pragmas is due to gcc not understanding '#pragma ident' in Xlib.h on OpenSolaris.
+ for TEST_CFLAG in -Wno-pointer-sign -Wno-unused-value -fno-strict-aliasing \
+--- configure.ac.orig  2010-10-19 23:19:54.000000000 +0300
++++ configure.ac       2011-05-29 17:17:27.000000000 +0300
+@@ -82,6 +82,9 @@
+    [x86_64])
+       userSpaceBitness="64"
+       ;;
++   [amd64])
++      userSpaceBitness="64"
++      ;;
+    [*])
+       AC_MSG_ERROR([Unknown architecture.])
+       ;;
+@@ -880,7 +883,7 @@
+ 
+ ### General flags / actions
+ CFLAGS="$CFLAGS -Wall"
+-CFLAGS="$CFLAGS -Werror"
++#CFLAGS="$CFLAGS -Werror"
+ 
+ # -Wno-unknown-pragmas is due to gcc not understanding '#pragma ident' in Xlib.h on OpenSolaris.
+ for TEST_CFLAG in -Wno-pointer-sign -Wno-unused-value -fno-strict-aliasing \
diff -ruN open-vm-tools.orig/files/patch-scripts-Makefile open-vm-tools/files/patch-scripts-Makefile
--- open-vm-tools.orig/files/patch-scripts-Makefile     2010-06-06 17:55:58.000000000 +0300
+++ open-vm-tools/files/patch-scripts-Makefile  2011-05-29 18:05:40.000000000 +0300
@@ -9,3 +9,14 @@
  conf_SCRIPTS = ./common/vm-support ./common/statechange.subr \
        $(defaultscripts)
  vmwsrcdir = $(confdir)/scripts/vmware
+--- scripts/Makefile.am.orig   2011-05-29 17:46:51.000000000 +0300
++++ scripts/Makefile.am        2011-05-29 17:47:00.000000000 +0300
+@@ -3,7 +3,7 @@
+ defaultscripts += suspend-vm-default
+ defaultscripts += resume-vm-default
+ 
+-confdir = /etc/vmware-tools
++confdir = ${prefix}/share/vmware-tools
+ 
+ conf_SCRIPTS = ./common/vm-support
+ conf_SCRIPTS += ./common/statechange.subr


>Release-Note:
>Audit-Trail:
>Unformatted: