ports/156993: lang/v8 missing dependency to devel/libexecinfo

[L Campbell]

>Number:         156993
>Category:       ports
>Synopsis:       lang/v8 missing dependency to devel/libexecinfo
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 13 03:10:10 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     L Campbell
>Release:        RELENG_8
>Organization:
Ironclad Mobile
>Environment:
FreeBSD  8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011     root at mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
Attempting to compile lang/v8 without devel/libexec info gives the following compile error:

g++ -o obj/release/platform-freebsd.o -c -Wall -Werror -W -Wno-unused-parameter -Wnon-virtual-dtor -m64 -O3 -fomit-frame-pointer -fdata-sections -ffunction-sections -ansi -fno-rtti -fno-exceptions -fvisibility=hidden -Wall -Werror -W -Wno-unused-parameter -Wnon-virtual-dtor -m64 -O3 -fomit-frame-pointer -fdata-sections -ffunction-sections -ansi -DV8_TARGET_ARCH_X64 -DV8_FAST_TLS -DENABLE_DEBUGGER_SUPPORT -DENABLE_VMSTATE_TRACKING -DENABLE_LOGGING_AND_PROFILING -Isrc -I/usr/local/include -Isrc src/platform-freebsd.cc
src/platform-freebsd.cc:46:56: error: execinfo.h: No such file or directory
src/platform-freebsd.cc: In static member function 'static int v8::internal::OS::StackWalk(v8::internal::Vector<v8::internal::OS::StackFrame>)':
src/platform-freebsd.cc:325: error: 'backtrace' was not declared in this scope
src/platform-freebsd.cc:327: error: 'backtrace_symbols' was not declared in this scope
scons: *** [obj/release/platform-freebsd.o] Error 1
scons: building terminated because of errors.
*** Error code 2

Which indicates a missing dependency on libexecinfo.
>How-To-Repeat:
# On a clean system
cd /usr/ports/lang/v8 && make BATCH=yes install clean
>Fix:
Add devel/libexecinfo as a build dependency:

--- Makefile.orig	2011-05-12 15:48:01.000000000 -0500
+++ Makefile	2011-05-12 15:57:47.000000000 -0500
@@ -22,6 +22,8 @@
 		SNAPSHOT "Enable snapshots" Off \
 		SHARED "Build shared library" Off
 
+BUILD_DEPENDS=	${NONEXISTENT}:${PORTSDIR}/devel/libexecinfo
+
 .include <bsd.port.options.mk>
 
 SCONS_ARGS=

Patch attached with submission follows:

--- Makefile.orig	2011-05-12 15:48:01.000000000 -0500
+++ Makefile	2011-05-12 15:57:47.000000000 -0500
@@ -22,6 +22,8 @@
 		SNAPSHOT "Enable snapshots" Off \
 		SHARED "Build shared library" Off
 
+BUILD_DEPENDS=	${NONEXISTENT}:${PORTSDIR}/devel/libexecinfo
+
 .include <bsd.port.options.mk>
 
 SCONS_ARGS=


>Release-Note:
>Audit-Trail:
>Unformatted: