ports/156902: collectd memory leak

[Thorkill]

>Number:         156902
>Category:       ports
>Synopsis:       collectd memory leak
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 09 09:00:19 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Thorkill
>Release:        8.X
>Organization:
>Environment:
>Description:
meta_data_create() creates a mutex but meta_data_destroy() does not 'destroys' it leave 64 bytes not freed. running collectd over few hours depending on how much hosts report data will allocate much memory.


>How-To-Repeat:
just run collectd with network plungin as server and let hosts report data to it.
>Fix:
patch attached

Patch attached with submission follows:

--- src/meta_data.c.bak	2011-05-09 08:21:35.000000000 +0000
+++ src/meta_data.c	2011-05-09 08:21:39.000000000 +0000
@@ -215,6 +215,7 @@
     return;
 
   md_entry_free (md->head);
+  pthread_mutex_destroy(&md->lock);
   free (md);
 } /* }}} void meta_data_destroy */
 



>Release-Note:
>Audit-Trail:
>Unformatted: