ports/157605: [PATCH] databases/postgis: enable GUI for shp2pgsql loader

[Rainer Hurling]

>Number:         157605
>Category:       ports
>Synopsis:       [PATCH] databases/postgis: enable GUI for shp2pgsql loader
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 04 11:50:07 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Rainer Hurling
>Release:        9.0-CURRENT
>Organization:
>Environment:
FreeBSD xxx.xxx.xxx 9.0-CURRENT FreeBSD 9.0-CURRENT #0: Sun May 29 08:10:43 CEST 2011 xxx at xxx.xxx.xx:/usr/obj/usr/src/sys/XXX amd64
>Description:
databases/postgis builds PostGIS itself, but also the command line tool version of the loader 'shp2pgsql', but not the GUI version. The GUI version can be used as standalone or better within PgAdmin3 (databases/pgadmin3) to directly convert shapefiles and load them into an open PostgreSQL database.

To be able to recognize 'shp2pgsql-gui', PgAdmin3 on FreeBSD also needs an entry in its plugins.ini file. I will submit a PR for it when the PostGIS port installs the GUI version.

/usr/local/share/pgadmin3/plugins.ini:
;
; PostGIS shp2pgsql-gui (Unix):
;
Title=PostGIS Shapefile and DBF loader
Command="$$PGBINDIR/shp2pgsql-gui" -h $$HOSTNAME -p $$PORT -U $$USERNAME -d $$DATABASE
Description=Open a PostGIS ESRI Shapefile or Plain dbf loader to the current database.
KeyFile=$$PGBINDIR/shp2pgsql-gui
Platform=unix
ServerType=postgresql
Database=Yes
SetPassword=Yes

>How-To-Repeat:
cd /usr/ports/databases/postgis
make clean && make install


After that there is no 'shp2pgsql-gui' installed in /usr/local/bin/.


>Fix:
The following patch should also install the GUI version 'shp2pgsl'. In addition I removed two unnecessary whitespaces.



Patch attached with submission follows:

diff -Naur postgis.origin/Makefile postgis/Makefile
--- postgis.origin/Makefile	2011-05-04 01:37:41.000000000 +0200
+++ postgis/Makefile	2011-06-04 12:47:44.000000000 +0200
@@ -9,7 +9,7 @@
 PORTVERSION=	1.5.2
 CATEGORIES=	databases geography
 MASTER_SITES=	http://postgis.refractions.net/download/ \
-  		http://www.postgis.org/download/
+		http://www.postgis.org/download/
 
 MAINTAINER=	anderson at cnpm.embrapa.br
 COMMENT=	Adds support for geographic objects to PostgreSQL databases
@@ -33,7 +33,7 @@
 LDFLAGS+=	-L${LOCALBASE}/lib
 MAKE_ENV=	DATADIR=${DATADIR} DOCSDIR=${DOCSDIR}
 MAKE_JOBS_UNSAFE=	yes
-CONFIGURE_ARGS=	--with-projdir=${LOCALBASE}
+CONFIGURE_ARGS=	--with-projdir=${LOCALBASE} --with-gui
 
 .include <bsd.port.pre.mk>
 
diff -Naur postgis.origin/pkg-plist postgis/pkg-plist
--- postgis.origin/pkg-plist	2010-03-26 14:53:07.000000000 +0100
+++ postgis/pkg-plist	2011-06-04 12:41:53.000000000 +0200
@@ -1,5 +1,6 @@
 bin/pgsql2shp
 bin/shp2pgsql
+bin/shp2pgsql-gui
 lib/postgresql/liblwgeom.so
 lib/postgresql/liblwgeom.so.1
 lib/postgresql/postgis-1.5.so


>Release-Note:
>Audit-Trail:
>Unformatted: