ports/159022: sysutils/smartmontools periodic script enhancement

[Ari Sovijärvi]

>Number:         159022
>Category:       ports
>Synopsis:       sysutils/smartmontools periodic script enhancement
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 19 04:10:11 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Ari Sovijärvi
>Release:        8.2
>Organization:
>Environment:
FreeBSD server3 8.2-RELEASE-p1 FreeBSD 8.2-RELEASE-p1 #0: Wed Apr 27 19:27:33 EEST 2011     root at server3:/usr/obj/usr/src/sys/LOL-OK  amd64
>Description:
Majority of the periodic scripts output an empty line, following by a line that tells what they're doing before the actual program output. Smartctl's script is missing this part and atleast in all of my setups the output is right after NTP script's output.

I've included a small patch that makes smartmontools's periodic script output the empty line and title before running smartctl.
>How-To-Repeat:
Install sysutils/smartmontools, daily_status_smart_enable=y and see the daily run output mail.
>Fix:
Patch /usr/local/etc/periodic/daily/smart with attached patch.

Patch attached with submission follows:

diff -cB old/smart new/smart
*** old/smart	Tue Jul 19 06:43:26 2011
--- new/smart	Tue Jul 19 06:45:49 2011
***************
*** 35,40 ****
--- 35,42 ----
  rc=0
  case "${daily_status_smart_enable}" in
  	[Yy][Ee][Ss])
+ 		echo
+ 		echo 'SMART status:'
  		cd /dev
  		for device in ${daily_status_smart_devices}; do
  			device="${device#/dev/}"


>Release-Note:
>Audit-Trail:
>Unformatted: