ports/158803: sysutils/flexbackup calls dump without -L on mounted filesystems

[B.Euler]

>Number:         158803
>Category:       ports
>Synopsis:       sysutils/flexbackup calls dump without -L on mounted filesystems
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 11 14:30:09 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     B.Euler
>Release:        8.2-RELEASE
>Organization:
-
>Environment:
FreeBSD server.local 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011     root at mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
I'm doing backups of all my mounted filesystem (including / of course) with dump since it seems to be the best option for UFS filesystems (and restore -i just rocks).


However flexbackup calls dump without option "-L" when doing a backup of a mounted filesystem and such produces a warning when run:

Flexbackup calls dump without option "-L" when doing a backup of a mounted filesystem:

DUMP: WARNING: should use -L when dumping live read-write filesystems!
  DUMP: Date of this level 0 dump: Sat Jul  9 12:15:52 2011
  DUMP: Date of last level 0 dump: the epoch

I've patched my local version of flexbackup to get rid of this warning and to get reliable backups, see below. But this will then produce warnings of backups with flexbackup+dump on unmounted filesystems.
>How-To-Repeat:
* Install flexbackup from ports
* call flexbackup like "flexbackup -type dump -dir /tmp -device /home" where /tmp is a filesystem
>Fix:
Patch flexbackup:

1078c1078
<     $cmd .= "dump -L -C 16 -$level ";
---
>     $cmd .= "dump -$level ";

In addition of -L which creates a snapshot of the filesystem also enable caching with -C to improve performance.

>Release-Note:
>Audit-Trail:
>Unformatted: