ports/153874: cvs-devel port will core

[Dan Mahoney]

>Number:         153874
>Category:       ports
>Synopsis:       cvs-devel port will core
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 11 00:10:06 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Dan Mahoney
>Release:        FreeBSD 8.1-RELEASE amd64
>Organization:
ISC
>Environment:
System: FreeBSD bikeshed.isc.org 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:36:49 UTC 2010 root at mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64


>Description:

CVS-devel port (1.12.13_9) currently coredumps when tagging a release.

Per a developer, this is due to an argument parsing a file in myndbm.c:

"The FreeBSD man page says the first argument (line) will be treated as NULL if line_size == 0.  It is == 32 in my core dump"

>How-To-Repeat:

Build cvs-devel from source, attempt to tag a release.  It will coredump.

>Fix:

Simple one line patch:

%diff -u ./work/cvs-1.12.13/src/myndbm.c.orig  ./work/cvs-1.12.13/src/myndbm.c
--- ./work/cvs-1.12.13/src/myndbm.c.orig        2011-01-10 23:53:25.000000000 +0000
+++ ./work/cvs-1.12.13/src/myndbm.c     2011-01-10 23:53:33.000000000 +0000
@@ -213,7 +213,7 @@
 mydbm_load_file (FILE *fp, List *list, char *filename)
 {
     char *line = NULL;
-    size_t line_size;
+    size_t line_size = 0;
     char *value;
     size_t value_allocated;
     char *cp, *vp;



>Release-Note:
>Audit-Trail:
>Unformatted: