ports/153650: [maintainer update] audio/libmikmod

[Anonymous]

The following reply was made to PR ports/153650; it has been noted by GNATS.

From: Anonymous <swell.k at gmail.com>
To: Gleb Sushko <neuroworker at gmail.com>
Cc: freebsd-gnats-submit at FreeBSD.org
Subject: Re: ports/153650: [maintainer update] audio/libmikmod
Date: Mon, 03 Jan 2011 19:01:04 +0300

 Gleb Sushko <neuroworker at gmail.com> writes:
 
 > @@ -6,16 +6,12 @@
 >  #
 >  
 >  PORTNAME=	libmikmod
 > -PORTVERSION=	3.1.11
 > -PORTREVISION=	2
 > +PORTVERSION=	3.1.12
 > +PORTREVISION=	3
 
 You don't need to bump PORTREVISION when updating PORTVERSION.
 
 > @@ -41,8 +37,6 @@
 >  
 >  post-extract:
 >  	@${RM} -f ${WRKSRC}/docs/mikmod.info-*
 > -
 > -post-patch:
 >  	@${REINPLACE_CMD} \
 >  		-e 's|\$$CFLAGS -pthread|\$$CFLAGS ${PTHREAD_CFLAGS}|g' \
 >  		-e 's|-pthread \$$REENTRANT|\$$REENTRANT ${PTHREAD_CFLAGS}|g' \
 
 
 Why? `make extract' should produce non-modified sources.
 
 > diff -ruN old/files/patch-CVE mikmod/files/patch-CVE
 > --- old/files/patch-CVE	1970-01-01 07:00:00.000000000 +0700
 > +++ mikmod/files/patch-CVE	2011-01-03 21:41:32.000000000 +0700
 
 Please, don't remove CVE identifer from patch name. libmikmod has more
 than one.
 
 http://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=libmikmod