ports/154571: [PATCH] databases/memcached: memcached_flags not used

[Dan Rowe]

>Number:         154571
>Category:       ports
>Synopsis:       [PATCH] databases/memcached: memcached_flags not used
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 07 14:20:09 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Dan Rowe
>Release:        8.1-RELEASE amd64
>Organization:
CSN Stores
>Environment:
FreeBSD BOMemCache01.csnzoo.com 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:36:49 UTC 2010     root at mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
The Memcached port includes the description for the memcached_flags rc.conf variable, but it doesn't seem to make use of it. I don't see it in the memcached rc script and i'm not sure if the ${name}_flags is a global variable.


>How-To-Repeat:
add any additional memcached_flags entry to your rc.conf and restart the service.
>Fix:
By making a change to the memcached rc script to add in the memcached_flags to the command_args variable it successfully included the flags when starting the service. Attached is a potential patch to the memcached script that works for our environment.

Patch attached with submission follows:

--- memcached   2011-01-26 08:26:10.000000000 -0500
+++ memcached_flags     2011-02-07 08:03:32.000000000 -0500
@@ -24,10 +24,12 @@

 : ${memcached_enable="NO"}
 : ${memcached_user="nobody"}
+: ${memcached_flags=""}

 command=/usr/local/bin/memcached
-command_args="-d -u ${memcached_user}"
+command_args="-d -u ${memcached_user} ${memcached_flags}"

 unset memcached_user
+unset memcached_flags

 run_rc_command "$1"

>Release-Note:
>Audit-Trail:
>Unformatted: