ports/154538: [ patch ] MySQL 55 client/server compiled with diferent behavior than MySQL 51 client/server

[Dan Lukes]

>Number:         154538
>Category:       ports
>Synopsis:       [ patch ] MySQL 55 client/server compiled with diferent behavior than MySQL 51 client/server
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Feb 05 22:40:08 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Dan Lukes
>Release:        FreeBSD 8.1-RELEASE-p2 amd64
>Organization:
Obludarium
>Environment:
databases/mysql55-client/Makefile,v 1.107 2011/01/13 09:15:22
databases/mysql55-server/Makefile,v 1.272 2011/01/13 09:15:22
>Description:
A)
Both MySQL 51 and MySQL 55 client can be compiled either with internal libedit (source's default) or system's libedit
The 51 client force unconditionally compilation with system libedit
The 55 client force unconditionally compilation with embedded libedit

Unfortunatelly, those libedits have diferent behavior so user interface changed. UI become diferent not only to previous
MySQL behavior, but it also diverge from UI of other system utilities that use system libedit
It cause unnecesarry discomfort to user as embedded libedit doesn't offer new or better function to user.
Even worse, both libedits have different format of history file, but store the data into same filename - so after
upgrade all users have they histories destroyed with no warning

B)
Both MySQL 51 and MySQL 55 server can be compiled either without (source's default) or with LIBWRAP
The 51 server force unconditionally compilation with libwrap
The 55 server force unconditionally compilation without libwrap

It cause diferent server behavior.
>How-To-Repeat:
>Fix:
It would be nice to either
1) restore same "port defaults" as has been forced in 51 - e.g. system libedit and use of libwrap
or
2) create WITH_* knobs that allow system administrator to request "51" compatible behavior

The attached patch implement 1) variant 
(e.g. non-configurable return to 51 behavior = unconditional compilation with system's libedit and libwrap)
	

--- databases/mysql55-client/Makefile.ORIG	2011-02-05 22:59:51.000000000 +0100
+++ databases/mysql55-client/Makefile	2011-02-05 22:57:55.000000000 +0100
@@ -21,7 +21,7 @@
 
 CONFLICTS_INSTALL=	mysql-client-[34].* mysql-client-5.[0-46-9].*
 
-CMAKE_ARGS=	-DWITHOUT_SERVER=1
+CMAKE_ARGS=	-DWITH_LIBEDIT=OFF -DWITHOUT_SERVER=1
 
 USE_LDCONFIG=	${PREFIX}/lib/mysql
 
--- databases/mysql55-server/Makefile.ORIG	2011-01-13 17:56:45.000000000 +0100
+++ databases/mysql55-server/Makefile	2011-02-05 22:58:55.000000000 +0100
@@ -39,8 +39,10 @@
 		-DINSTALL_SQLBENCHDIR="share/mysql" \
 		-DINSTALL_SUPPORTFILESDIR="share/mysql"
 
+CMAKE_ARGS+=	-DWITH_LIBWRAP=ON
+
 .ifdef USE_MYSQL
-.error You have `USE_MYSQL' variable defined either in environment or in make(1) arguments. Please undefine and try again.
+.error You have 'USE_MYSQL' variable defined either in environment or in make(1) arguments. Please undefine and try again.
 .endif
 
 .include <bsd.port.options.mk>
>Release-Note:
>Audit-Trail:
>Unformatted: