ports/163434: xfce4-utils dependency on xlockmore is superfluous
Thomas Zander
thomas.e.zander at googlemail.com
Sun Dec 18 17:30:12 UTC 2011
>Number: 163434
>Category: ports
>Synopsis: xfce4-utils dependency on xlockmore is superfluous
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Sun Dec 18 17:30:11 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Thomas Zander
>Release:
>Organization:
>Environment:
>Description:
A recent update to the xfce4-utils port to xfce4-utils-4.8.3_1 introduced a runtime dependency on x11/xlockmore, presumably to support the 'lock screen' function. However, this is not necessary since 'lock screen' also works fine if xscreensaver is installed.
>How-To-Repeat:
>Fix:
Attached patch makes the dependency optional and lets the user choose whether the run dependency should be enforced or not.
Please consider this solution for the benefit of users trying to avoid superfluous dependencies on their machines.
Patch attached with submission follows:
diff -ruN /usr/ports/sysutils/xfce4-utils/Makefile xfce4-utils/Makefile
--- /usr/ports/sysutils/xfce4-utils/Makefile 2011-12-11 13:56:18.000000000 +0100
+++ xfce4-utils/Makefile 2011-12-18 13:33:14.965215652 +0100
@@ -7,7 +7,7 @@
PORTNAME= xfce4-utils
PORTVERSION= 4.8.3
-PORTREVISION= 1
+PORTREVISION= 2
CATEGORIES= sysutils xfce
MASTER_SITES= ${MASTER_SITE_XFCE}
MASTER_SITE_SUBDIR= src/xfce/xfce-utils/${PORTVERSION:R}
@@ -19,8 +19,6 @@
BUILD_DEPENDS= p5-XML-Parser>=2.40:${PORTSDIR}/textproc/p5-XML-Parser
-RUN_DEPENDS= xlock:${PORTSDIR}/x11/xlockmore
-
DOCSDIR= ${PREFIX}/share/doc/${PORTNAME:S/4//}
CONFIGURE_ARGS+=--with-xsession-prefix=${PREFIX} \
@@ -38,7 +36,8 @@
USE_XORG= x11
OPTIONS= DBUS "Enable D-BUS support" on \
- NLS "Enable Native Language Support" on
+ NLS "Enable Native Language Support" on \
+ XLOCK "Use xlock for 'lock screen'" off
.include <bsd.port.pre.mk>
@@ -60,6 +59,10 @@
PLIST_SUB+= NLS="@comment "
.endif
+.if defined(WITH_XLOCK)
+RUN_DEPENDS+= xlock:${PORTSDIR}/x11/xlockmore
+.endif
+
post-install:
@-update-desktop-database
>Release-Note:
>Audit-Trail:
>Unformatted:
More information about the freebsd-ports-bugs
mailing list