ports/160315: kdenlive crashes on 2 pass VOB rendering

[Ed Johnstone (johnedstone)]

>Number:         160315
>Category:       ports
>Synopsis:       kdenlive crashes on 2 pass VOB rendering
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 30 15:10:10 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Ed Johnstone (johnedstone)
>Release:        8.1-RELEASE-p2
>Organization:
personal
>Environment:
uname -rimp
8.1-RELEASE-p2 amd64 amd64 GENERIC
>Description:
I've reported a bug, in the melt port, in the kdenlive bug tracking system

This ticket is http://www.kdenlive.org/mantis/view.php?id=2274

The patch to fix the bug was made, and it is listed there.

The port tracker for kdenlive and melt is
avilla at FreeBSD.org

So, this is just a notification to avilla (thanks avilla for your work) that this patch to melt has been applied in

"mlt git commit 31948b"

I'll be looking forward to this change being incorporated in the melt port
>How-To-Repeat:
Here is the opening paragraph that I listed in the kdenlive bug report

"""
Rendering 2-pass VOB reports crast at end of 2nd pass put, file appears okay

This does not happen on a single pass.

This happens whether there is a sound or not.

This happens whether the original file is a .mp4 or .dv

Details
========
Note: running fluxbox, not kde as a desktop

pkg_info -XI '^(kdenlive|ffmpeg|mlt|fluxbox)-' |awk '{print $1}'
ffmpeg-0.7.1_4,1
fluxbox-1.3.1
kdenlive-0.7.8_2
mlt-0.6.2_4
"""
>Fix:
As reported in the kdenlive bug tracker:

Fixed in mlt git commit 31948b

diff --git a/src/modules/avformat/consumer_avformat.c b/src/modules/avformat/consumer_avformat.c
index 179815c..5741d5c 100644
--- a/src/modules/avformat/consumer_avformat.c
+++ b/src/modules/avformat/consumer_avformat.c
@@ -851,7 +851,6 @@ static AVStream *add_video_stream( mlt_consumer consumer, AVFormatContext *oc, A
                         fclose( f );
                         logbuffer[size] = '\0';
                         c->stats_in = logbuffer;
- mlt_properties_set_data( properties, "_logbuffer", logbuffer, 0, ( mlt_destructor )av_free, NULL );
                     }
                 }
             }
@@ -951,6 +950,7 @@ void close_video(AVFormatContext *oc, AVStream *st)
     if ( st && st->codec )
     {
         avformat_lock();
+ av_freep( &st->codec->stats_in );
         avcodec_close(st->codec);
         avformat_unlock();
     } 


>Release-Note:
>Audit-Trail:
>Unformatted: