ports/160055: [PATCH] games/anki: eliminate py-pysqlite2x dependency

Ruslan Mahmatkhanov cvs-src at yandex.ru
Wed Aug 24 12:20:09 UTC 2011


>Number:         160055
>Category:       ports
>Synopsis:       [PATCH] games/anki: eliminate py-pysqlite2x dependency
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 24 12:20:09 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Ruslan Mahmatkhanov
>Release:        9.0-BETA1
>Organization:
>Environment:
9.0-BETA1 i386
>Description:
- bump USE_PYTHON to 2.5+ (the point is to not depend on python24)
- since it now requires 2.5+ use databases/py-sqlite3 
  instead of databases/py-pysqlite2x
- while here use GOOGLE_CODE instead of ${MASTER_SITE_GOOGLE_CODE}
- bump port revision because of dependencies change

I checked the code. They use this pattern when using sqlite binding:

 18 try:
 19     from pysqlite2 import dbapi2 as sqlite
 20 except ImportError:
 21     try:
 22         from sqlite3 import dbapi2 as sqlite
 23     except:
 24         raise Exception("Please install pysqlite2 or python2.5")

So nothing will be broken with sqlite3.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- Makefile.inc.orig	2011-07-21 00:09:09.000000000 +0400
+++ Makefile.inc	2011-08-24 16:03:49.000000000 +0400
@@ -2,12 +2,12 @@
 
 PORTNAME=	anki
 PORTVERSION=	1.2.8
-PORTREVISION?=	0
+PORTREVISION?=	1
 CATEGORIES=	games
-MASTER_SITES=	${MASTER_SITE_GOOGLE_CODE}
+MASTER_SITES=	GOOGLE_CODE
 EXTRACT_SUFX=	.tgz
 
-USE_PYTHON=	yes
+USE_PYTHON=	2.5+
 USE_GETTEXT=	yes
 USE_PYDISTUTILS=	easy_install
 
@@ -36,7 +36,7 @@
 		false
 .else
 BUILD_DEPENDS=	${PYNUMPY} \
-		py*-pysqlite>=0:${PORTSDIR}/databases/py-pysqlite23 \
+		${PYTHON_SITELIBDIR}/_sqlite3.so:${PORTSDIR}/databases/py-sqlite3 \
 		py*-sqlalchemy06>=0:${PORTSDIR}/databases/py-sqlalchemy06 \
 		py*-game>=0:${PORTSDIR}/devel/py-game \
 		py*-simplejson>=0:${PORTSDIR}/devel/py-simplejson \


>Release-Note:
>Audit-Trail:
>Unformatted:



More information about the freebsd-ports-bugs mailing list