ports/160050: [patch] databases/postgresql84-server: unbreak for 9.x

[Eygene Ryabinkin]

>Number:         160050
>Category:       ports
>Synopsis:       [patch] databases/postgresql84-server: unbreak for 9.x
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 24 09:50:07 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Eygene Ryabinkin
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
Code Labs
>Environment:

System: FreeBSD 9.0-CURRENT amd64

>Description:

PostgreSQL 8.4, 9.0 and 9.1 are currently marked as BROKEN for 9-CURRENT.

The breakage comes from the fact that
 a. configure script detects gssapi_krb5 as the GSSAPI library;
 b. configure instructs ld to use flag '--as-needed', so when
    we're linking to the bare GSSAPI libraries and no Kerberos
    gssapi_krb5 will be thrown away from linking, because no
    symbols are used from there.

>How-To-Repeat:

Look at
 * http://www.freebsd.org/cgi/cvsweb.cgi/ports/databases/postgresql84-server/Makefile
 * http://www.freebsd.org/cgi/cvsweb.cgi/ports/databases/postgresql90-server/Makefile

Try to compile postgresql91-server with GSSAPI set to 'yes'
and no Kerberos.

>Fix:

The patch is available at
  http://codelabs.ru/fbsd/ports/postgresql/unbreak-GSSAPI-support.diff

It was tested on my Tinderbox.  Here are the QA pages:
 * http://codelabs.ru/fbsd/ports/qa/databases/postgresql84/8.4.8_1
 * http://codelabs.ru/fbsd/ports/qa/databases/postgresql90/9.0.4_2
 * http://codelabs.ru/fbsd/ports/qa/databases/postgresql91/9.1.b3

I had also tested the patched version for postgresql90 at our local
LXR instance that indexes around 20 distinct versions of FreeBSD,
Linux and XNU kernel sources -- no regressions found yet.

It will be good to have PostgreSQL 8.4 (as being the currently-default
version) to be buildable before 9.0 will come out.
>Release-Note:
>Audit-Trail:
>Unformatted: