ports/159522: [PATCH] ports-mgmt/portlint: correct detection of WWW format warning
Sunpoet Po-Chuan Hsieh
sunpoet at FreeBSD.org
Fri Aug 5 05:20:11 UTC 2011
>Number: 159522
>Category: ports
>Synopsis: [PATCH] ports-mgmt/portlint: correct detection of WWW format warning
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri Aug 05 05:20:11 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Sunpoet Po-Chuan Hsieh
>Release: FreeBSD 8.2-STABLE amd64
>Organization:
The FreeBSD Project
>Environment:
System: FreeBSD bonjour.sunpoet.net 8.2-STABLE FreeBSD 8.2-STABLE #0: Sat Jul 9 23:23:51 CST
>Description:
- Correct detection of WWW format warning
This patch eliminates the warning of WWW::* at the beginning of the line in pkg-descr.
For WWW::* perl modules, we might have WWW::* in pkg-descr.
It triggers portlint warning of WWW format as follows.
WARN: /home/FreeBSD/ports/www/p5-FEAR-API/pkg-descr: WWW URL, :Mechanize, should begin with "http://" or "https://".
Let portlint warn only when it begins with "WWW:\s+" instead of "WWW:\s*"
Here's the list of affected pkg-descr:
mail/p5-WWW-GMail/pkg-descr
mail/p5-WWW-Hotmail/pkg-descr
net-p2p/p5-WWW-BitTorrent/pkg-descr
www/p5-FEAR-API/pkg-descr
www/p5-WWW-Babelfish/pkg-descr
www/p5-WWW-Baseball-NPB/pkg-descr
www/p5-WWW-Facebook-API/pkg-descr
www/p5-WWW-FreeProxy/pkg-descr
www/p5-WWW-Google-News-TW/pkg-descr
www/p5-WWW-HatenaDiary/pkg-descr
www/p5-WWW-HatenaStar/pkg-descr
www/p5-WWW-Link/pkg-descr
www/p5-WWW-Mechanize/pkg-descr
www/p5-WWW-Mechanize-DecodedContent/pkg-descr
www/p5-WWW-Mechanize-Plugin-phpBB/pkg-descr
www/p5-WWW-Mechanize-SpamCop/pkg-descr
www/p5-WWW-Mediawiki-Client/pkg-descr
www/p5-WWW-Mixi/pkg-descr
www/p5-WWW-Myspace/pkg-descr
www/p5-WWW-OpenSVN/pkg-descr
www/p5-WWW-OpenSearch/pkg-descr
www/p5-WWW-Robot/pkg-descr
www/p5-WWW-RobotRules-Parser/pkg-descr
www/p5-WWW-Scraper-ISBN-Driver/pkg-descr
www/p5-WWW-Scraper-ISBN-Record/pkg-descr
www/p5-WWW-Scripter-Plugin-Ajax/pkg-descr
www/p5-WWW-Shorten-KUSO/pkg-descr
www/p5-WWW-Spinn3r/pkg-descr
www/p5-WWW-TV/pkg-descr
www/p5-WWW-Wikipedia/pkg-descr
www/py-mechanize/pkg-descr
Port maintainer (marcus at FreeBSD.org) is cc'd.
Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:
--- portlint-2.13.6_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/ports-mgmt/portlint/Makefile,v
retrieving revision 1.146
diff -u -u -r1.146 Makefile
--- Makefile 26 Jun 2011 21:33:13 -0000 1.146
+++ Makefile 4 Aug 2011 08:17:52 -0000
@@ -9,6 +9,7 @@
PORTNAME= portlint
PORTVERSION= 2.13.6
+PORTREVISION= 1
CATEGORIES= ports-mgmt
MASTER_SITES= # none
DISTFILES= # none
Index: src/portlint.pl
===================================================================
RCS file: /home/ncvs/ports/ports-mgmt/portlint/src/portlint.pl,v
retrieving revision 1.123
diff -u -u -r1.123 portlint.pl
--- src/portlint.pl 21 Jul 2011 05:02:54 -0000 1.123
+++ src/portlint.pl 4 Aug 2011 08:17:52 -0000
@@ -630,7 +630,7 @@
"returns. Strip all carriage returns (e.g. run dos2unix) ".
"in $file.");
}
- if (/^WWW:\s*(\S*)/) {
+ if (/^WWW:\s+(\S*)/) {
my $wwwurl = $1;
if ($wwwurl !~ m|^https?://|) {
&perror("WARN", $file, -1, "WWW URL, $wwwurl should begin ".
--- portlint-2.13.6_1.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
More information about the freebsd-ports-bugs
mailing list