ports/156460: Problem with help in octave plays havoc with FreeBSD tinderbox building system

[Stephen Montgomery-Smith]

>Number:         156460
>Category:       ports
>Synopsis:       Problem with help in octave plays havoc with FreeBSD tinderbox building system
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Apr 17 19:40:08 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Stephen Montgomery-Smith
>Release:        FreeBSD 7.4-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD wilberforce 7.4-PRERELEASE FreeBSD 7.4-PRERELEASE #0: Wed Dec 1 20:53:06 CST 2010 stephen at wilberforce:/usr/obj/usr/src/sys/GENERIC i386


	
>Description:
	

There is a problem with "help" in octave.  This has a side effect of making the FreeBSD tinderbox build system fail for the octave-forge-* ports.
>How-To-Repeat:
	

cd /a-directory-for-which-you-dont-have-write-permission
octave --eval "help inv"

>Fix:

	

These fixes include a new file: files/patch-scripts+help+__makeinfo__.m 
Also I felt it was appropriate to bump PORTREVISION.

I have also submitted the problem to the octave bug tracker.  However, I think it needs to be fixed ASAP, so can we have the patches included in the octave and octave-devel until the upstream fix makes its way downstream?

diff -urN /usr/ports/math/octave/Makefile octave/Makefile
--- /usr/ports/math/octave/Makefile	2010-12-04 07:32:38.000000000 +0000
+++ octave/Makefile	2011-04-17 18:16:27.000000000 +0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	octave
 PORTVERSION=	3.2.4
-PORTREVISION=	4
+PORTREVISION=	5
 CATEGORIES=	math
 MASTER_SITES=	ftp://ftp.octave.org/pub/octave/ \
 		ftp://ftp.u-aizu.ac.jp/pub/SciEng/numanal/Octave/bleeding-edge/
diff -urN /usr/ports/math/octave/files/patch-scripts+help+__makeinfo__.m octave/files/patch-scripts+help+__makeinfo__.m
--- /usr/ports/math/octave/files/patch-scripts+help+__makeinfo__.m	1970-01-01 00:00:00.000000000 +0000
+++ octave/files/patch-scripts+help+__makeinfo__.m	2011-04-17 18:13:29.000000000 +0000
@@ -0,0 +1,12 @@
+diff -ur scripts/help-orig/__makeinfo__.m scripts/help/__makeinfo__.m
+--- scripts/help-orig/__makeinfo__.m	2011-04-17 18:11:18.000000000 +0000
++++ scripts/help/__makeinfo__.m	2011-04-17 18:10:02.000000000 +0000
+@@ -124,7 +124,7 @@
+   
+   unwind_protect
+     ## Write Texinfo to tmp file
+-    [fid, name, msg] = mkstemp ("octave_help_XXXXXX", true);
++    [fid, name, msg] = mkstemp (sprintf("%s/octave_help_XXXXXX",P_tmpdir()), true);
+     fwrite (fid, text);
+     fclose (fid);
+ 



diff -urN /usr/ports/math/octave-devel/Makefile octave-devel/Makefile
--- /usr/ports/math/octave-devel/Makefile	2010-12-04 07:32:38.000000000 +0000
+++ octave-devel/Makefile	2011-04-17 18:16:40.000000000 +0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	octave
 PORTVERSION=	3.3.50
-PORTREVISION=	5
+PORTREVISION=	6
 CATEGORIES=	math
 MASTER_SITES=	ftp://ftp.octave.org/pub/octave/bleeding-edge/ \
 		ftp://ftp.eos.hokudai.ac.jp/pub/GNU/misc/octave/bleeding-edge/\
diff -urN /usr/ports/math/octave-devel/files/patch-scripts+help+__makeinfo__.m octave-devel/files/patch-scripts+help+__makeinfo__.m
--- /usr/ports/math/octave-devel/files/patch-scripts+help+__makeinfo__.m	1970-01-01 00:00:00.000000000 +0000
+++ octave-devel/files/patch-scripts+help+__makeinfo__.m	2011-04-17 18:15:01.000000000 +0000
@@ -0,0 +1,12 @@
+diff -ur scripts/help-orig/__makeinfo__.m scripts/help/__makeinfo__.m
+--- scripts/help-orig/__makeinfo__.m	2011-04-17 18:11:18.000000000 +0000
++++ scripts/help/__makeinfo__.m	2011-04-17 18:10:02.000000000 +0000
+@@ -124,7 +124,7 @@
+   
+   unwind_protect
+     ## Write Texinfo to tmp file
+-    [fid, name, msg] = mkstemp ("octave_help_XXXXXX", true);
++    [fid, name, msg] = mkstemp (sprintf("%s/octave_help_XXXXXX",P_tmpdir()), true);
+     fwrite (fid, text);
+     fclose (fid);
+ 
>Release-Note:
>Audit-Trail:
>Unformatted: