ports/156293: [patch] kdenetwork4: googletalk plugin for kopete fails to build

[Oleg Sidorkin]

>Number:         156293
>Category:       ports
>Synopsis:       [patch] kdenetwork4: googletalk plugin for kopete fails to build
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 09 08:50:11 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Oleg Sidorkin
>Release:        RELENG_8
>Organization:
>Environment:
window# uname -a
FreeBSD window.trtk.ru 8.2-STABLE FreeBSD 8.2-STABLE #0: Tue Mar  8 11:59:41 MSK 2011     olsi at window.trtk.ru:/usr/obj/usr/src/sys/QUADKERNEL  amd64

>Description:
If all dependencies required to build googletalk plugin are met, googletalk plugin fails to build with the following error:

/data/build/usr/ports/net/kdenetwork4/work/kdenetwork-4.6.2/kopete/protocols/jabber/googletalk/libjingle/talk/base/httpcommon.cc: In function 'bool talk_base::HttpDateToSeconds(const std::string&, long unsigned int*)':
/data/build/usr/ports/net/kdenetwork4/work/kdenetwork-4.6.2/kopete/protocols/jabber/googletalk/libjingle/talk/base/httpcommon.cc:378: error: invalid operands of types 'long unsigned int' and 'char* ()(int, int)' to binary 'operator-'

>How-To-Repeat:
1) cd to net/kdenetwork4 and run make configure
2) check google talk plugin is enabled after configure
3)run make
>Fix:
changing line 374 of 
kdenetwork-4.6.2/kopete/protocols/jabber/googletalk/libjingle/talk/base/httpcommon.cc

from
#ifdef OSX
to 
#if defined (OSX) || defined(__FreeBSD__)
fixes the problem for me.

Patch attached with submission follows:

*** ./kopete/protocols/jabber/googletalk/libjingle/talk/base/httpcommon.cc.orig	2011-04-08 22:53:54.449396376 +0400
--- ./kopete/protocols/jabber/googletalk/libjingle/talk/base/httpcommon.cc	2011-04-08 22:54:52.017857851 +0400
***************
*** 371,377 ****
      }
      gmt = non_gmt + kTimeZoneOffsets[zindex] * 60 * 60;
    }
! #ifdef OSX
    tm *tm_for_timezone = localtime((time_t *)&gmt);
    *seconds = gmt + tm_for_timezone->tm_gmtoff;
  #else
--- 371,377 ----
      }
      gmt = non_gmt + kTimeZoneOffsets[zindex] * 60 * 60;
    }
! #if defined (OSX) || defined(__FreeBSD__) 
    tm *tm_for_timezone = localtime((time_t *)&gmt);
    *seconds = gmt + tm_for_timezone->tm_gmtoff;
  #else


>Release-Note:
>Audit-Trail:
>Unformatted: