ports/150235: sysutils/smartmontools build system bug

[Alex Samorukov]

The following reply was made to PR ports/150235; it has been noted by GNATS.

From: Alex Samorukov <samm at os2.kiev.ua>
To: Garrett Wollman <wollman at FreeBSD.org>
Cc: bug-followup at FreeBSD.org, developers at FreeBSD.org
Subject: Re: ports/150235: sysutils/smartmontools build system bug
Date: Sun, 05 Sep 2010 21:28:31 +0200

 On 09/05/2010 08:53 PM, Garrett Wollman wrote:
 >
 >
 >> Your commit will break smartmontools functionality, as i mentioned
 >> before. Thats why i`m against it. Try to read before posting.
 >>      
 > What commit?  I haven't committed anything.
 >    
 Ok, proposed patch. Your proposed patch will break smartmontools 
 functionality - thats why i`m not able to accept it.
 >    
 >> The required file was never included in the /usr/include. And it was
 >> changed more then once from the beginning.
 >>      
 > If anything in userland links against a kernel header, then that
 > header needs to be installed in /usr/include, end of story.
 > -I/usr/src/sys is never acceptable in userland code.
 >    
 There is a number of ports using /usr/src, e.g. - linux_kdump or 
 emulators/rtc. Please, do PR agains every port depending on source tree, 
 i will not feel so alone in that case ;-) Once again - if i will remove 
 this include it will break smarmontools functionality. Thats the end of 
 the story. As port maintainer and smartmontools developer - i`m against 
 this. Rewrite your patch or i will ask to close this PR as bogus.
 > Of course one needs to upgrade all ports in the middle of the upgrade
 > cycle, if one wishes to have a working system at the end of it --
 > particularly in the case of something that uses CAMIOCOMMAND, which
 > does not have any backwards-compatibility mechanism (hmmm, another bug
 > here).
 >    
 I`m always upgrading ports after system system update and never had a 
 problems with this.