ports/151807: Remove Legacy USE_BISON

[Eitan Adler]

>Number:         151807
>Category:       ports
>Synopsis:       Remove Legacy USE_BISON
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 29 08:00:19 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Eitan Adler
>Release:        
>Organization:
>Environment:
>Description:
bsd.port.mk has some code to change
USE_BISON=yes to USE_BISON=build

When I checked ports I only found two ports that were affected.

Attached is a patch to change those two ports and remove the relevant lines from bsd.port.mk
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Mk/bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.650
diff -u -r1.650 bsd.port.mk
--- Mk/bsd.port.mk	13 Oct 2010 09:04:30 -0000	1.650
+++ Mk/bsd.port.mk	23 Oct 2010 01:44:19 -0000
@@ -371,8 +371,7 @@
 #				  should not be used in Makefile.
 ##
 # USE_BISON		- Implies that the port uses bison in one way or another:
-#				  'yes' (backwards compatibility) - use bison for building
-#				  new features: 'build', 'run', 'both', implying build,
+#				  'build', 'run', 'both', implying build,
 #				  runtime, and both build/run dependencies
 ##
 # USE_IMAKE		- If set, this port uses imake.
@@ -2040,13 +2039,6 @@
 .if defined(USE_BISON)
 _BISON_DEPENDS=	bison:${PORTSDIR}/devel/bison
 
-# XXX: backwards compatibility
-. if ${USE_BISON:L} == "yes"
-USE_BISON=	build
-pre-everything::
-	@${ECHO_MSG} "WARNING: USE_BISON=yes deprecated, use build/run/both"
-. endif
-
 . if ${USE_BISON:L} == "build"
 BUILD_DEPENDS+= ${_BISON_DEPENDS}
 . elif ${USE_BISON:L} == "run"
Index: lang/q/Makefile
===================================================================
RCS file: /home/ncvs/ports/lang/q/Makefile,v
retrieving revision 1.45
diff -u -r1.45 Makefile
--- lang/q/Makefile	24 Jul 2010 19:49:57 -0000	1.45
+++ lang/q/Makefile	23 Oct 2010 01:44:19 -0000
@@ -24,7 +24,7 @@
 		xslt.2:${PORTSDIR}/textproc/libxslt \
 		ggi.2:${PORTSDIR}/graphics/libggi
 
-USE_BISON=	yes
+USE_BISON=	build
 USE_ICONV=	yes
 USE_TK=		84
 USE_LDCONFIG=	yes
Index: x11-wm/i3/Makefile
===================================================================
RCS file: /home/ncvs/ports/x11-wm/i3/Makefile,v
retrieving revision 1.11
diff -u -r1.11 Makefile
--- x11-wm/i3/Makefile	29 Jun 2010 16:01:36 -0000	1.11
+++ x11-wm/i3/Makefile	23 Oct 2010 01:44:19 -0000
@@ -21,7 +21,7 @@
 		yajl.1:${PORTSDIR}/devel/yajl
 
 USE_XORG=	x11
-USE_BISON=	yes
+USE_BISON=	build
 USE_XLIB=	yes
 USE_BZIP2=	yes
 USE_GMAKE=	yes


>Release-Note:
>Audit-Trail:
>Unformatted: