ports/151482: [PATCH] lxsession doesn't build if NLS unselected

[Aldis Berjoza]

>Number:         151482
>Category:       ports
>Synopsis:       [PATCH] lxsession doesn't build if NLS unselected
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 15 22:00:17 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Aldis Berjoza
>Release:        FreeBSD-8.1-Release
>Organization:
>Environment:
FreeBSD b32.bsdroot.lv 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Sun Jul 25 01:24:28 EEST 2010     killasmurf86 at root.bsdroot.lv:/usr/obj/usr/src/sys/GENERICpp  i386
>Description:
The binary will be installed in /usr/local/bin

http://lxde.org/

Have fun!

===>  Building for lxsession-0.4.4
gmake  all-recursive
gmake[1]: Entering directory `/usr/obj/usr/ports/x11-wm/lxsession/work/lxsession-0.4.4'
Making all in lxsession
gmake[2]: Entering directory `/usr/obj/usr/ports/x11-wm/lxsession/work/lxsession-0.4.4/lxsession'
cc -DHAVE_CONFIG_H -I. -I..    -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include   -DPACKAGE_LOCALE_DIR=\""/usr/local/lib/locale"\" -Werror-implicit-function-declaration -O2 -pipe -march=pentiumpro -fno-strict-aliasing -MT lxsession-lxsession.o -MD -MP -MF .deps/lxsession-lxsession.Tpo -c -o lxsession-lxsession.o `test -f 'lxsession.c' || echo './'`lxsession.c
In file included from lxsession.c:39:
xevent.h:26:22: error: X11/Xlib.h: No such file or directory
In file included from lxsession.c:39:
xevent.h:30: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
In file included from lxsession.c:40:
settings-daemon.h:33: error: expected ')' before '*' token
gmake[2]: *** [lxsession-lxsession.o] Error 1
gmake[2]: Leaving directory `/usr/obj/usr/ports/x11-wm/lxsession/work/lxsession-0.4.4/lxsession'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/obj/usr/ports/x11-wm/lxsession/work/lxsession-0.4.4'
gmake: *** [all] Error 2
*** Error code 1

Stop in /usr/ports/x11-wm/lxsession.

>How-To-Repeat:
cd to ports dir
make config
unselect NLS
make
>Fix:
apply patch

Patch attached with submission follows:

diff -u lxsession.bak/Makefile lxsession/Makefile
--- lxsession.bak/Makefile	2010-10-16 00:52:33.297284038 +0300
+++ lxsession/Makefile	2010-10-16 00:53:13.821369562 +0300
@@ -7,6 +7,7 @@
 
 PORTNAME=	lxsession
 PORTVERSION=	0.4.4
+PORTREVISION=	1
 CATEGORIES=	x11-wm
 MASTER_SITES=	SF/lxde/LXSession%20%28session%20manager%29/LXSession%20${PORTVERSION}
 
@@ -27,12 +28,13 @@
 
 MAN1=		lxsession.1 lxsession-logout.1
 
-.if !defined(WITHOUT_NLS)
-USE_GETTEXT=	yes
-PLIST_SUB+=	NLS=""
 CPPFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
 CONFIGURE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
+
+.if !defined(WITHOUT_NLS)
+USE_GETTEXT=	yes
+PLIST_SUB+=	NLS=""
 .else
 CONFIGURE_ARGS+=--disable-nls
 PLIST_SUB+=	NLS="@comment "


>Release-Note:
>Audit-Trail:
>Unformatted: