ports/151626: [NEW PORT] databases/py-flask-sqlalchemy, add SQLAlchemy support to Flask
Alexey Dokuchaev
danfe at nsu.ru
Tue Nov 9 04:00:25 UTC 2010
The following reply was made to PR ports/151626; it has been noted by GNATS.
From: Alexey Dokuchaev <danfe at nsu.ru>
To: bug-followup at FreeBSD.org, duchateau.olivier at gmail.com
Cc:
Subject: Re: ports/151626: [NEW PORT] databases/py-flask-sqlalchemy, add SQLAlchemy support to Flask
Date: Tue, 9 Nov 2010 09:52:58 +0600
Nice work, could of minor nits:
- Date created in Makefile header shold probably be lined up with port
name (also, in here, official "Flask-SQLAlchemy" could be used as the
port name since it's more descriptive)
- Two spaces after PKGNAMEPREFIX=, space after DISTNAME= (should be tabs)
- Missing another leading tab in the second line of RUN_DEPENDS=
- Spaces after PYDISTUTILS_PKGNAME= and PYDISTUTILS_PKGVERSION= should
be tabs
- LICENSE could probably be placed after COMMENT, but that's more just a
matter of personal taste
- Tab after WWW: line in pkg-descr shoud be space
More information about the freebsd-ports-bugs
mailing list