ports/151887: net/samba35: patch-source3__smbd__negprot.c braking smbd and possibly not needed

[Bartosz Stec]

>Number:         151887
>Category:       ports
>Synopsis:       net/samba35: patch-source3__smbd__negprot.c braking smbd and possibly not needed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 02 14:20:08 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Bartosz Stec
>Release:        8.1-STABLE
>Organization:
IT4Pro
>Environment:
FreeBSD 8.1-STABLE #14: Mon Nov  1 12:38:54 CET 2010 i386

>Description:
After upgrading net/samba33 port, which was obsolete and removed, to net/samba35, I found that multifuntional office devices (like canon IR2270, IR2020i, IR1020i) cannot connect to smb shares anymore, while Windows PC's have no such problems. T

I was also able to connect from Windows using login/password combination used by office machines. Hovewer none of them could connect itself, and smbd logs says:

[2010/11/02 13:30:49.862220,  0] smbd/sesssetup.c:1703(reply_sesssetup_and_X)
  reply_sesssetup_and_X:  Attempted encrypted session setup without negprot denied!

Playing with smb.conf options and google doesn't help, it seems that only some Mac OS X's have similiar problems with latest samba releases. From IR2270 Panel I was able to browse network neighbourhood and FreeBSD based Samba server was visible and accesible. Any try to write scanned file to share ends with error.
>How-To-Repeat:
#portinstall net/samba35

then connect from some non-windows device, office equipment talking to SMB preferably.
>Fix:
While investigating possible causes, I found that removing patch 'patch-source3__smbd__negprot.c', rebuildig and reinstalling port fix this issue. None side effects of patch removal has been seen for now. So I guess that patch brakes protocol negotiations in some cases, and it's possible that it isn't needed at all.

>Release-Note:
>Audit-Trail:
>Unformatted: