ports/147103: [patch] editors/emacs-nox11: skip OPTIONS and use WITHOUT_DBUS

[Anonymous]

The following reply was made to PR ports/147103; it has been noted by GNATS.

From: Anonymous <swell.k at gmail.com>
To: wahjava at gmail.com (Ashish SHUKLA)
Cc: phoffman at proper.com,  Giorgos Keramidas <keramida at freebsd.org>,  bug-followup at FreeBSD.org
Subject: Re: ports/147103: [patch] editors/emacs-nox11: skip OPTIONS and use WITHOUT_DBUS
Date: Thu, 27 May 2010 09:18:45 +0000

 wahjava at gmail.com (Ashish SHUKLA) writes:
 
 > Anonymous  writes:
 >> I agree only on X11 knob. There is no need to list it in OPTIONS
 >> variable, ifdef is enough. DBUS unlike X11 can stand on its own, though.
 >
 > DBUS is also a knob as per ${PORTSDIR}/KNOBS file.
 
 And? That file is for common names so that users don't invent D-BUS or
 DBUS-1. There are a few ports that list DBUS in OPTIONS,
 e.g. www/firefox*, graphics/gimp-app, dns/dnsmasq.
 
 Please, re-add DBUS knob to OPTIONS variable.
 
 >>> - Removal of libintl checks from configure.
 >
 >> Why? Do they interfere?
 >
 > That causes emacs to be linked with '-lintl'.
 
 Not it doesn't. Try to build emacs with Xaw and without m17n, rsvg2,
 dbus-glib and gconf2. If it doesn't want to link with -lintl then why
 bother?
 
 
 >
 > [...]
 >
 >> BTW, I've dropped -lintl from LDFLAGS in emacs port and successfully
 >> built it with Xaw toolkit. Again, if m17n really needs gettext symbols
 >> on linking then libdata/pkgconfig/m17n-*.pc should be fixed rather than
 >> emacs.
 >
 > Yes, same here.
 
 Thanks, seen your diff.
 
 >
 >>> Also I can remove GTK2 OPTION, and use it as default toolkit if
 >>> MOTIF/XAW/XAW3D aren't defined, as GTK2 is also a KNOB.
 >
 >> Agree, ifdef is enough. But you should mention it in OPTIONS, e.g.
 >
 >>   XAW "Use Athena widgets instead of GTK+ 2.0" OFF
 >
 > Instead of mentioning GTK+ in every OPTION, I've added a 'pre-everything'
 > target.
 >
 > Attached is the diff file of the cleaned up port.
 
 Can you move this line
 
   CONFIGURE_ENV+= CPPFLAGS="-I${LOCALBASE}/include"
 
 before <bsd.port.options.mk>, e.g. just after GNU_CONFIGURE?
 
 And drop dbus-glib dependency, please. Next time check ldd(1) output on
 nox11 build.
 
 >
 > Thanks