ports/147103: [patch] editors/emacs-nox11: skip OPTIONS and use WITHOUT_DBUS

[Anonymous]

The following reply was made to PR ports/147103; it has been noted by GNATS.

From: Anonymous <swell.k at gmail.com>
To: wahjava at gmail.com (Ashish SHUKLA)
Cc: phoffman at proper.com,  Giorgos Keramidas <keramida at freebsd.org>,  bug-followup at FreeBSD.org
Subject: Re: ports/147103: [patch] editors/emacs-nox11: skip OPTIONS and use WITHOUT_DBUS
Date: Thu, 27 May 2010 06:55:21 +0000

 wahjava at gmail.com (Ashish SHUKLA) writes:
 
 > Hi Anonymous,
 >
 > Thanks for your diff. 
 >
 > I've few objections to the diff:
 >
 > - WITHOUT_DBUS is unneeded, as DBUS can work without X11.
 
 D-Bus is rarely used outside of X11/Gnome apps. WITHOUT_DBUS makes
 emacs-nox11 package (not port) have no dependencies at all. And
 installing dbus on e.g. server makes no sense.
 
 > - No need to skip OPTIONS.
 
 Why we should duplicate OPTIONS in nox11 slave port? Users are advised
 to refer to the main port if they need them. -nox11 port is only for
 package (pkg_add) and really lazy users.
 
 >
 > Following are the changes I've in mind for editors/emacs, which also try to
 > fix the problem being solved by the current diff:
 >
 > - Removing X11 and DBUS options from the editors/emacs port, as they're KNOBS
 >   and user can {dis,en}able them in there make.conf(5) or at command-line,
 >   there is no need for them to listed in OPTIONS, wrong decision by me in the
 >   first place.
 
 I agree only on X11 knob. There is no need to list it in OPTIONS
 variable, ifdef is enough. DBUS unlike X11 can stand on its own, though.
 
 >
 > - Adding a CONFLICTS for 'emacs-nox11-*' package in editors/emacs.
 >
 > - Removal of ALSA checks from configure.
 >
 > - Removal of libintl checks from configure.
 
 Why? Do they interfere?
 
 >
 > - And adding USE_GETTEXT=yes only when port builds with M17N support, as m17n
 >   relies on gettext.
 >
 
 You're fixing wrong port! devel/m17n-lib doesn't even build without
 gettext here. I'm not sure if only having WITHOUT_NLS= in make.conf is
 enough to break it but looking at direct dependcies, none of them
 unconditionally enable NLS.
 
 --- a.diff begins here ---
 Index: devel/m17n-lib/Makefile
 ===================================================================
 RCS file: /a/.cvsup/ports/devel/m17n-lib/Makefile,v
 retrieving revision 1.31
 diff -u -p -r1.31 Makefile
 --- devel/m17n-lib/Makefile	3 May 2010 06:39:40 -0000	1.31
 +++ devel/m17n-lib/Makefile	27 May 2010 06:01:07 -0000
 @@ -25,6 +25,7 @@ RUN_DEPENDS=	m17n-db>=1.6.1:${PORTSDIR}/
  
  MAKE_JOBS_UNSAFE=	yes
  
 +USE_GETTEXT=	yes
  USE_XORG=	ice sm x11 xaw xft xt
  USE_GNOME=	gnometarget libxml2 pkgconfig
  USE_AUTOTOOLS=	autoconf:262 libtool:22
 --- a.diff ends here ---
 
 Looking at ifdef for HAVE_M17N_FLT in emacs I don't see it using any
 gettext specific symbols.
 
 BTW, I've dropped -lintl from LDFLAGS in emacs port and successfully
 built it with Xaw toolkit. Again, if m17n really needs gettext symbols
 on linking then libdata/pkgconfig/m17n-*.pc should be fixed rather than
 emacs.
 
 > Also I can remove GTK2 OPTION, and use it as default toolkit if
 > MOTIF/XAW/XAW3D aren't defined, as GTK2 is also a KNOB.
 
 Agree, ifdef is enough. But you should mention it in OPTIONS, e.g.
 
   XAW "Use Athena widgets instead of GTK+ 2.0" OFF
 
 user would not know what is used by default otherwise.
 
 >
 > Thanks