ports/147097: port multimedia/x264 unconditionally wants devel/binutils

[Pavel Gubin]

>Number:         147097
>Category:       ports
>Synopsis:       port multimedia/x264 unconditionally wants devel/binutils
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 26 21:10:08 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Pavel Gubin
>Release:        8.0-RELEASE-p2
>Organization:
Lazy.
>Environment:
FreeBSD hammer.local 8.0-RELEASE-p2 FreeBSD 8.0-RELEASE-p2 #2: Wed Mar 17 15:45:56 MSK 2010     pg at hammer.local:/usr/obj/usr/src/sys/GnomeKTR  i386
>Description:
Port multimedia/x264 unconditionally wants devel/binutils for GNU as 2.17 (instead of 2.15 in base system) to compile inline SSE3 code. But sometimes there is no need to use exactly inline SSE3, and fetch-build-install devel/binutils just for that.

Added knob ASMSSE3, it allows to not use inline SSE3 and devel/binutils.
>How-To-Repeat:
Try to compile port without devel/binutils installed.
>Fix:
Apply the patch to /usr/ports/multimedia/Makefile

--- Makefile.orig       2010-05-17 16:00:56.000000000 +0400
+++ Makefile    2010-05-27 00:39:33.000000000 +0400
@@ -18,8 +18,7 @@
 MAINTAINER=    mm at FreeBSD.org
 COMMENT?=      Library and tool for encoding H.264/AVC video streams
 
-BUILD_DEPENDS= yasm>=0.6.0:${PORTSDIR}/devel/yasm \
-               ${LOCALBASE}/bin/as:${PORTSDIR}/devel/binutils
+BUILD_DEPENDS= yasm>=0.6.0:${PORTSDIR}/devel/yasm
 
 USE_BZIP2=     yes
 EXTRACT_AFTER_ARGS?=   | ${TAR} -xf - --exclude .svn
@@ -33,12 +32,19 @@
                PGO "Enable Profile-Guided Optimization" Off \
                GCC44 "Use gcc 4.4+" Off \
                GPAC "Enable MPEG-4 Output" On \
-               X11_OUTPUT "Enable X11 Output" Off
+               X11_OUTPUT "Enable X11 Output" Off \
+               ASMSSE3 "Enable inline SSE3 asm" On
 
 CONFIGURE_ARGS+=       --extra-cflags="${CPPFLAGS} ${CFLAGS} -fPIC -I${LOCALBASE}/include -I${LOCALBASE}/include" \
                        --extra-ldflags="${LDFLAGS} -L${LOCALBASE}/lib -L${LOCALBASE}/lib" \
                        --enable-shared
 
+.if defined(WITHOUT_ASMSSE3)
+CONFIGURE_ARGS+=       --disable-asm
+.else
+BUILD_DEPENDS+=                ${LOCALBASE}/bin/as:${PORTSDIR}/devel/binutils
+.endif
+
 CONFIGURE_ENV+=                COMPILER_PATH=${LOCALBASE}/bin
 MAKE_ENV+=             COMPILER_PATH=${LOCALBASE}/bin
 


>Release-Note:
>Audit-Trail:
>Unformatted: