ports/146979: editors/emacs configuration ignores "-D WITHOUT_X11"

[Ashish SHUKLA]

The following reply was made to PR ports/146979; it has been noted by GNATS.

From: wahjava at gmail.com (Ashish SHUKLA)
To: Anonymous <swell.k at gmail.com>
Cc: Paul Hoffman <phoffman at proper.com>,  bug-followup at FreeBSD.org, Giorgos Keramidas <keramida at freebsd.org>
Subject: Re: ports/146979: editors/emacs configuration ignores "-D WITHOUT_X11"
Date: Wed, 26 May 2010 20:26:14 +0530

 --=-=-=
 Content-Transfer-Encoding: quoted-printable
 
 [CCing to keramida@ for his inputs, if there any]
 
 Anonymous  writes:
 > SOUND support is not related to X11. It may depend on alsa-lib when it's
 > installed but that's all. This should let you build with minimum
 > dependencies (only devel/gmake)
 
 SOUND support doesn't require ALSA on BSDs. It uses OSS, and works great.
 
 M-x play-sound-file works for me.
 
 But yes, Thanks for reminding that its not dependent upon X11, and I should
 take that WITHOUT_SOUND block from the WITHOUT_X11 block.
 
 >   $ make WITHOUT_X11=3D WITHOUT_DBUS=3D BATCH=3D
 
 > I'm not sure what GETTEXT is doing there, though. It's not used by emacs
 > directly and is useless for nox11 builds. And this comment gives pretty
 > clear answer in which specific case it's needed
 
 Right, we can take that out, or make that support optional via NLS knob, in
 case they later decide to use gettext functionality.
 
 >   # Solaris requires -lintl if you want strerror (which calls dgettext)
 >   # to return localized messages.
 >   AC_CHECK_LIB(intl, dgettext)
 
 > --- a.diff begins here ---
 > Index: editors/emacs/Makefile
 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 > RCS file: /a/.cvsup/ports/editors/emacs/Makefile,v
 > retrieving revision 1.95
 > diff -u -p -r1.95 Makefile
 > --- editors/emacs/Makefile	21 May 2010 19:51:04 -0000	1.95
 > +++ editors/emacs/Makefile	26 May 2010 05:12:18 -0000
 > @@ -28,8 +28,6 @@ GNU_CONFIGURE=3D	yes
 >  USE_GMAKE=3D	yes
 >  USE_BZIP2=3D	yes
 =20
 > -USE_GETTEXT=3D	yes
 > -
 >  MAN1=3D		b2m.1 ctags.1 ebrowse.1 emacs.1 emacsclient.1 etags.1 \
 >  		grep-changelog.1 rcs-checkin.1
 >  PLIST_SUB=3D	EMACS_VER=3D${EMACS_VER} EMACS_ARCH=3D${CONFIGURE_TARGET}
 > --- a.diff ends here ---
 
 Thanks for your diff, I'll modify/integrate it and file a PR.
 
 =2D-=20
 Ashish SHUKLA
 
 Sent via Gnus from GNU Emacs
 
 --=-=-=
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.15 (GNU/Linux)
 
 iQIcBAEBCgAGBQJL/TaOAAoJEMdGz6nnT6SwiMoP/0hbKgTLSyQMcG4/FuvOnHqF
 K45/c+HYUAdnkhPQPBIEOH7uAfzSJhwa8tBWfQCbCg9oQtCRGWmt5eiaCP+FlARx
 e8tJGm7UzJqsRxjHti77v8JOAz0HURCft890z89FL84h+gq8cwNtxTmop3/9IK+q
 6WfQWtS8BQYzQ9tOl/5+hSghQIMfgkJXPCfXIxrwtHazv1NSlXJMFrf7AuByVv1l
 4mpTmW5iRXN2NypddMStcvOgD1y7bw3Il/Qbx6jpgT+2Fna3jw0nG2BITsAhZkht
 FKU6zLekEdNyySrUhYJAMH00/WvMGDia91/o3QxF34cndMuw4ij4vfM0ugfGV0WD
 UZkMS6Mle/5rpJHKseZYnceQ91IDBaYn9f5TxH74oKIb8W18k0docbYY18ZgSDki
 OMtArZVLx2ezs9lZXRCG/rd3KmYhuuKeX7GBDM8qV/BgSAuxCHr/gHew4v4mhu6p
 exd1tcmIpf7Gs6D3se6QD+bYV3nNakwy3wqMqcKl8eQ9VZMkKc9ixhXzXHx9BSLl
 BwvpLmiN42rA00OdDj1+7Sxvd65xCwGldVizJAh22Xt/O3BSrp869h++5Oj0/YeJ
 JVAt4h22flsybzkWE51+jrh04YdoKNGumYK+Ay9M6R+25BufgTHsTHXD5IIvuZzI
 aOpYBLFEIOz6M0AQYuvQ
 =BqfT
 -----END PGP SIGNATURE-----
 --=-=-=--