ports/146870: hplip 3.10.5 installation problem

[Ross]

>Number:         146870
>Category:       ports
>Synopsis:       hplip 3.10.5 installation problem
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 23 22:06:50 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Ross
>Release:        8.0-RELEASE-p2
>Organization:
>Environment:
FreeBSD striker.local 8.0-RELEASE-p2 FreeBSD 8.0-RELEASE-p2 #0: Sun May 16 17:30:49 EEST 2010     root at striker.local:/usr/obj/mnt/coffin/FreeBSD/8.0-RELEASE/src/sys/STRIKER  amd64
>Description:
HPLIP only installs PPD files. /usr/local/share/hplip, where *.py scripts and other stuff should be is empty.
>How-To-Repeat:
cd /usr/ports/print/hplip
make install clean
>Fix:
configure script has the following lines:

 if test x$hpcups_only_build = xno && test x$hpijs_only_build = xno; then
  HPLIP_BUILD_TRUE=
  HPLIP_BUILD_FALSE='#'
else
  HPLIP_BUILD_TRUE='#'
  HPLIP_BUILD_FALSE=
fi
..
 if test x$hpcups_only_build = xno && test x$lite_build = xno && test x$hpijs_only_build = xno; then
  FULL_BUILD_TRUE=
  FULL_BUILD_FALSE='#'
else
  FULL_BUILD_TRUE='#'
  FULL_BUILD_FALSE=
fi


When these variables are set to '#' this effectively comments out many Makefile.in lines:

# data
@FULL_BUILD_TRUE@@HPLIP_BUILD_TRUE at modelsdir = $(hplipdir)/data/models
@FULL_BUILD_TRUE@@HPLIP_BUILD_TRUE at images_16x16dir = $(hplipdir)/data/images/16x16
@FULL_BUILD_TRUE@@HPLIP_BUILD_TRUE at images_24x24dir = $(hplipdir)/data/images/24x24
@FULL_BUILD_TRUE@@HPLIP_BUILD_TRUE at images_32x32dir = $(hplipdir)/data/images/32x32
@FULL_BUILD_TRUE@@HPLIP_BUILD_TRUE at images_64x64dir = $(hplipdir)/data/images/64x64

The solution is to remove  --enable-hpijs-only-build and --enable-hpcups-only-build from configure args.

Patch attached with submission follows:

--- Makefile.orig	2010-05-23 17:12:33.000000000 +0300
+++ Makefile	2010-05-23 17:14:24.000000000 +0300
@@ -33,10 +33,9 @@
 		--enable-foomatic-ppd-install \
 		--enable-foomatic-rip-hplip-install \
 		--enable-hpijs-install \
-		--enable-hpijs-only-build \
-		--enable-hpcups-only-build \
 		--enable-hpcups-install \
 		--enable-new-hpcups \
+		--disable-pp-build \
 		--with-icondir=${LOCALBASE}/share/applications \
 		--with-cupsbackenddir=${LOCALBASE}/libexec/cups/backend \
 		--with-cupsfilterdir=${LOCALBASE}/libexec/cups/filter \


>Release-Note:
>Audit-Trail:
>Unformatted: