ports/146863: [patch] lang/ruby19: remove extra `-g' from CFLAGS and WITH_DEBUG ifdef

[Anonymous]

>Number:         146863
>Category:       ports
>Synopsis:       [patch] lang/ruby19: remove extra `-g' from CFLAGS and WITH_DEBUG ifdef
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 23 22:06:32 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Anonymous
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
$ make showconfig
===> The following configuration options are available for ruby-1.9.1.376_1,1:
     RDOC=off "Build and install Rdoc indexes"
     DEBUG=off "Compile-in debug info"
>Description:
- configure script adds `-g' by default

  : ${CFLAGS=} ${cflags='${optflags} ${debugflags} ${warnflags}'}
  test $ac_cv_prog_cc_g = yes && : ${debugflags=-g}

- WITH_DEBUG is defined in bsd.port.mk, no need to duplicate it
  here. The ifdef should be removed from lang/ruby18, too.
>How-To-Repeat:
$ make
...
gcc -O2 -pipe -fno-strict-aliasing -O2 -g -Wall -Wno-parentheses  -fPIC -I. -I.ext/include/amd64-freebsd9 -I./include -I.  -DRUBY_EXPORT   -o main.o -c main.c
>Fix:
--- a.diff begins here ---
Index: lang/ruby18/Makefile
===================================================================
RCS file: /a/.cvsup/ports/lang/ruby18/Makefile,v
retrieving revision 1.146
diff -u -p -r1.146 Makefile
--- lang/ruby18/Makefile	6 Apr 2010 23:54:52 -0000	1.146
+++ lang/ruby18/Makefile	23 May 2010 12:28:46 -0000
@@ -83,11 +83,6 @@ PLIST_SUB+=	ONIGURUMA=""
 PLIST_SUB+=	ONIGURUMA="@comment "
 .endif
 
-.if defined(WITH_DEBUG)
-CFLAGS+=	-g
-STRIP=		# none
-.endif
-
 #
 # Disable doc generation if requested or docs disabled at all
 #
Index: lang/ruby19/Makefile
===================================================================
RCS file: /a/.cvsup/ports/lang/ruby19/Makefile,v
retrieving revision 1.6
diff -u -p -r1.6 Makefile
--- lang/ruby19/Makefile	16 Feb 2010 00:08:17 -0000	1.6
+++ lang/ruby19/Makefile	23 May 2010 12:18:02 -0000
@@ -63,11 +63,6 @@ PKGNAMESUFFIX=	#empty
 CFLAGS+=	${PTHREAD_CFLAGS}	# Keep this, else ruby will fail to load
 LDFLAGS+=	${PTHREAD_LIBS}		# libraries dependent op libpthread.
 
-.if defined(WITH_DEBUG)
-CFLAGS+=	-g
-STRIP=		# none
-.endif
-
 #
 # Disable doc generation if requested or docs disabled at all
 #
@@ -78,7 +73,8 @@ CONFIGURE_ARGS+=	--disable-install-doc
 .endif
 
 CONFIGURE_ENV=	CFLAGS="${CFLAGS}" \
-		LIBS="${LDFLAGS}"
+		LIBS="${LDFLAGS}" \
+		debugflags=
 
 .if ${RUBY_VER} == ${RUBY_DEFAULT_VER}
 MLINKS=		${RUBY_NAME}.1 ruby.1
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted: