ports/146769: [patch] misc/amanda-server requires net/samba3 with no way to use other samba ports

[Ricky Morse]

>Number:         146769
>Category:       ports
>Synopsis:       [patch] misc/amanda-server requires net/samba3 with no way to use other samba ports
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 20 17:50:02 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Ricky Morse
>Release:        8.0-RELEASE-p2/amd64
>Organization:
MGH Biostatistics Center
>Environment:
FreeBSD hedwig.mgh.harvard.edu 8.0-RELEASE-p2 FreeBSD 8.0-RELEASE-p2 #0: Tue Jan  5 21:11:58 UTC 2010     root at amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
If the "SAMBA" option is provided to the misc/amanda-server port, it requires the installation of net/samba3. There are several newer ports available (net/samba32, net/samba33, net/samba34). The port's makefile should allow this to be overruled.
>How-To-Repeat:
Install net/samba34, then misc/amanda-server with the SAMBA option. This will then start installing net/samba3.
>Fix:
I"ve attached a patch that allows the samba port used to be overridden (e.g. in /usr/local/etc/ports.conf).

Patch attached with submission follows:

--- Makefile.orig	2010-05-20 12:08:57.000000000 -0400
+++ Makefile	2010-05-20 12:09:02.000000000 -0400
@@ -125,8 +125,9 @@
 .endif
 
 .if defined (WITH_SAMBA)
-BUILD_DEPENDS+=	smbclient:${PORTSDIR}/net/samba34
-RUN_DEPENDS+=	smbclient:${PORTSDIR}/net/samba34
+SAMBA_PORT?=samba3
+BUILD_DEPENDS+=	smbclient:${PORTSDIR}/net/${SAMBA_PORT}
+RUN_DEPENDS+=	smbclient:${PORTSDIR}/net/s${SAMBA_PORT}
 CONFIGURE_ARGS+=	--with-smbclient=${PREFIX}/bin/smbclient
 .endif
 


>Release-Note:
>Audit-Trail:
>Unformatted: