ports/146752: VirtualBox assertion: Lock/Unlock is not implemented

[Mike Makonnen]

>Number:         146752
>Category:       ports
>Synopsis:       VirtualBox assertion: Lock/Unlock is not implemented
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 20 10:50:00 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Mike Makonnen
>Release:        FreeBSD 9-CURRENT
>Organization:
>Environment:
FreeBSD rogue.mike.lan 9.0-CURRENT FreeBSD 9.0-CURRENT #2 r208116: Sat May 15 23:38:15 EAT 2010     mtm at rogue.mike.lan:/data/build/obj/data/build/src/sys/ROGUE  amd64
>Description:
When trying to install Windows XP SP2 as a guest OS from the hosts DVD drive the following assertion is triggered right after the setup program finishes loading drivers: Lock/Unlock is not implemented.  I noticed this after the recent upgrade to VirtualBox 3.1.8.  I also did a world and kernel upgrade in the mean time so I'm not sure if that may have had something to do with it. The Host is a 9-Current amd64 box.
>How-To-Repeat:
Try to install Windows XP as a guest OS from a DVD Drive.
>Fix:
The problem is a missing compile time #define that makes it think FreeBSD doesn't support locking of the DVD drive door. The attached patch fixes the problem for me.

Patch attached with submission follows:

--- src/VBox/Devices/Storage/DrvHostDVD.cpp.orig	2010-05-20 10:28:06.000000000 +0300
+++ src/VBox/Devices/Storage/DrvHostDVD.cpp	2010-05-20 10:37:47.000000000 +0300
@@ -224,7 +224,7 @@
  */
 static DECLCALLBACK(int) drvHostDvdDoLock(PDRVHOSTBASE pThis, bool fLock)
 {
-#ifdef RT_OS_DARWIN
+#if defined(RT_OS_FREEBSD) || defined(RT_OS_DARWIN)
     uint8_t abCmd[16] =
     {
         SCSI_PREVENT_ALLOW_MEDIUM_REMOVAL, 0, 0, 0, fLock, 0,


>Release-Note:
>Audit-Trail:
>Unformatted: