ports/146419: [patch] devel/directfb: FREETYPE2 enabled unconditionally

b. f. bf1783 at googlemail.com
Mon May 10 07:00:18 UTC 2010


The following reply was made to PR ports/146419; it has been noted by GNATS.

From: "b. f." <bf1783 at googlemail.com>
To: Anonymous <swell.k at gmail.com>
Cc: bug-followup at freebsd.org
Subject: Re: ports/146419: [patch] devel/directfb: FREETYPE2 enabled 
	unconditionally
Date: Mon, 10 May 2010 06:52:35 +0000

 On 5/10/10, Anonymous <swell.k at gmail.com> wrote:
 > "b. f." <bf1783 at googlemail.com> writes:
 >> On 5/10/10, Anonymous <swell.k at gmail.com> wrote:
 >>> And ports/144765 does exactly that, i.e. adds OPTIONS, except it doesn't
 >>> remove above statement.
 >>
 >> Good.  But it should also remove these lines, or users will not be
 >> able to disable auto-detection and -configuration of freetype support
 >> when freetype is installed, as you wanted.
 >
 > With my patch they can. OPTIONS either define WITH_BLAH=yes or
 > WITHOUT_BLAH=yes depending on whether knob was selected or not.
 > So when both are defined WITHOUT_BLAH takes precedence.
 >
 > It works with and without ports/144765.
 
 Yes, but as I've already explained, if the OPTIONS framework is used,
 your patch shouldn't be necessary -- it just makes one more variable
 to keep track of, adding another potential source of error.  So just
 switch to OPTIONS, and get rid of the auto-detection.
 
 >
 >>>
 >>> And the purpose of things like HAVE_GNOME is exactly to intervene with
 >>> user's decision and enable things based on what's already installed.
 >>>
 >>
 >> I guess here you're talking my separate response to PR ports/146385.
 >> I'm not sure what you mean by this.
 >
 > No, I'm talking about cases like in graphics/gimp-app
 >
 >   .if defined(WITH_GVFS) || ${HAVE_GNOME:Mgvfs}!=""
 >   LIB_DEPENDS+=   gnome-keyring.0:${PORTSDIR}/security/gnome-keyring
 >   USE_GNOME+=     gvfs
 >   .  if ${HAVE_GNOME:Mlibgnomeui}!=""
 >   USE_GNOME+=     libgnomeui
 >   .  endif
 >   .endif
 >
 > Note, the port does not provide a way to disable GVFS when it's installed
 
 
 Oh, I see.  Yes, another species of auto-detection, specific to Gnome.
  To reduce the amount of work involved in maintaining all of the
 components, they sometimes take choice away from the user with things
 like this. But again, this shouldn't be necessary, and usually isn't
 desirable.  The state of the Gnome ports is not ideal, and is
 evolving.  Where possible, the recommended practice is to leave the
 choice to the user.  That's what you are seeking here, right?  Why not
 do it more simply?
 
 b.



More information about the freebsd-ports-bugs mailing list