ports/146419: [patch] devel/directfb: FREETYPE2 enabled unconditionally

[Anonymous]

>Number:         146419
>Category:       ports
>Synopsis:       [patch] devel/directfb: FREETYPE2 enabled unconditionally
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 09 01:10:01 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Anonymous
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
LOCALBASE=/usr/pkg
PREFIX=$HOME/aaa
>Description:
Makefile is read after make.conf, you can't undefine variables there.

  $ __MAKE_CONF=/etc/make.conf make -dd
  Caching ....done
  Caching /usr/share/mk...done
  expanding "sys.mk".../usr/share/mk/sys.mk
  Searching for /etc/make.conf...Looking for "/etc/make.conf"...failed. Returning NULL
  Searching for bsd.compat.mk.../usr/share/mk...here...returning /usr/share/mk/bsd.compat.mk
  .include /usr/share/mk/bsd.compat.mk
  Searching for bsd.cpu.mk.../usr/share/mk...here...returning /usr/share/mk/bsd.cpu.mk
  .include /usr/share/mk/bsd.cpu.mk
  Searching for BSDmakefile...failed.
  Searching for BSDmakefile.../usr/share/mk...failed.
  Searching for makefile...failed.
  Searching for makefile.../usr/share/mk...failed.
  Searching for Makefile...failed.
  Searching for Makefile.../usr/share/mk...failed.
  Searching for .depend...failed.
  Searching for .depend.../usr/share/mk...failed.
  make: no target to make.

You can guess that freetype2 support is enabled unconditionally when the
library is installed according to

  .if exists(${LOCALBASE}/lib/libfreetype.so.9)
  WITH_FREETYPE2= yes
  .endif
>How-To-Repeat:
1. install print/freetype2
2. try to find a way to disable freetype2 support in directfb via
make.conf
>Fix:
Introduce WITHOUT_FREETYPE2 to cope when WITH_FREETYPE2 is defined. This
should work fine with OPTIONS from ports/144765.
--- a.diff begins here ---
Index: devel/directfb/Makefile
===================================================================
RCS file: /a/.cvsup/ports/devel/directfb/Makefile,v
retrieving revision 1.37
diff -u -p -r1.37 Makefile
--- devel/directfb/Makefile	28 Mar 2010 06:33:02 -0000	1.37
+++ devel/directfb/Makefile	9 May 2010 00:54:47 -0000
@@ -33,7 +33,7 @@ PLIST_SUB+=	DIRECTFB_VERSION=${PORTVERSI
 WITH_FREETYPE2=	yes
 .endif
 
-.if defined(WITH_FREETYPE2)
+.if defined(WITH_FREETYPE2) && !defined(WITHOUT_FREETYPE2)
 LIB_DEPENDS+=	freetype.9:${PORTSDIR}/print/freetype2
 CONFIGURE_ARGS+=	--enable-freetype
 PLIST_SUB+=	FREETYPE2=""
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted: