ports/144976: import of zlib 1.2.4 may break code defining _LARGEFILE64_SOURCE

[Javier Villavicencio]

>Number:         144976
>Category:       ports
>Synopsis:       import of zlib 1.2.4 may break code defining _LARGEFILE64_SOURCE
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 23 13:40:02 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Javier Villavicencio
>Release:        8.0
>Organization:
Gentoo
>Environment:
FreeBSD Alniyat 8.0-RELEASE FreeBSD Gentoo 8.0 #0: Tue Mar 16 04:27:57 ARST 2010     root at Alniyat:/usr/src/sys-8.0-r0/i386/compile/ALNIYAT  i386
>Description:
Just a heads up.

On svn rev. 205471 zlib was updated to 1.2.4, this version contains this piece of code in zlib.h:

#ifdef _LARGEFILE64_SOURCE
   ZEXTERN gzFile ZEXPORT gzopen64 OF((const char *, const char *));
   ZEXTERN off64_t ZEXPORT gzseek64 OF((gzFile, off64_t, int));
   ZEXTERN off64_t ZEXPORT gztell64 OF((gzFile));
   ZEXTERN off64_t ZEXPORT gzoffset64 OF((gzFile));
   ZEXTERN uLong ZEXPORT adler32_combine64 OF((uLong, uLong, off64_t));
   ZEXTERN uLong ZEXPORT crc32_combine64 OF((uLong, uLong, off64_t));

Some software may define _LARGEFILE64_SOURCE and, off64_t apparently being a glibc thing, by also including this particular zlib.h it will cause a compilation failure.


This was discovered by Alexis Ballier while working on Gentoo/FreeBSD, reported on our bugzilla: 

http://bugs.gentoo.org/show_bug.cgi?id=310209
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted: