ports/144716: [ERROR] cannot portupgrade editors/openoffice.org-3-devel

[Andrei Lavreniyuk]

>Number:         144716
>Category:       ports
>Synopsis:       [ERROR] cannot portupgrade editors/openoffice.org-3-devel
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 13 12:10:03 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Andrei Lavreniyuk
>Release:        FreeBSD 8.0-STABLE
>Organization:
Technica-03, Inc.
>Environment:
FreeBSD datacenter.technica-03.local 8.0-STABLE FreeBSD 8.0-STABLE #0: Thu Mar 11 19:36:33 EET 2010     root at datacenter.technica-03.local:/usr/obj/usr/src/sys/SMP64  amd64
>Description:

Already did begin not fashionable to use the utility of portlint? It is possible even to shut out such child's errors.
>How-To-Repeat:
1.
# portupgrade -f ru-openoffice.org-3.3.20100301
** Makefile possibly broken: editors/openoffice.org-3-devel:
        "Makefile", line 209: Need an operator
        make: fatal errors encountered -- cannot continue
/usr/local/sbin/portupgrade:1473:in `get_pkgname': Makefile broken (MakefileBrokenError)
        from /usr/local/sbin/portupgrade:623
        from /usr/local/sbin/portupgrade:614:in `each'
        from /usr/local/sbin/portupgrade:614
        from /usr/local/sbin/portupgrade:588:in `catch'
        from /usr/local/sbin/portupgrade:588
        from /usr/local/lib/ruby/1.8/optparse.rb:1310:in `call'
        from /usr/local/lib/ruby/1.8/optparse.rb:1310:in `parse_in_order'
        from /usr/local/lib/ruby/1.8/optparse.rb:1306:in `catch'
        from /usr/local/lib/ruby/1.8/optparse.rb:1306:in `parse_in_order'
        from /usr/local/lib/ruby/1.8/optparse.rb:1254:in `catch'
        from /usr/local/lib/ruby/1.8/optparse.rb:1254:in `parse_in_order'
        from /usr/local/lib/ruby/1.8/optparse.rb:1248:in `order!'
        from /usr/local/lib/ruby/1.8/optparse.rb:1241:in `order'
        from /usr/local/sbin/portupgrade:565:in `main'
        from /usr/local/lib/ruby/1.8/optparse.rb:791:in `initialize'
        from /usr/local/sbin/portupgrade:229:in `new'
        from /usr/local/sbin/portupgrade:229:in `main'
        from /usr/local/sbin/portupgrade:2213


2.
/usr/ports/editors/openoffice.org-3-devel# portlint
"Makefile", line 209: Need an operator
make: fatal errors encountered -- cannot continue
"Makefile", line 209: Need an operator
make: fatal errors encountered -- cannot continue
Use of uninitialized value in list assignment at /usr/local/bin/portlint line 267.
Use of uninitialized value in list assignment at /usr/local/bin/portlint line 267.
Use of uninitialized value $makevar{"PATCHDIR"} in concatenation (.) or string at /usr/local/bin/portlint line 291.
Use of uninitialized value $i in string at /usr/local/bin/portlint line 299.
Use of uninitialized value $i in string eq at /usr/local/bin/portlint line 300.
Use of uninitialized value in string eq at /usr/local/bin/portlint line 300.
Use of uninitialized value $makevar{"DISTFILES"} in string eq at /usr/local/bin/portlint line 300.
Use of uninitialized value $makevar{"OPTIONS"} in pattern match (m//) at /usr/local/bin/portlint line 1456.
WARN: Makefile: [304]: possible direct use of command "file" found. use ${FILE} instead.
Use of uninitialized value $makevar{"GNU_CONFIGURE"} in string ne at /usr/local/bin/portlint line 2003.
Use of uninitialized value $masterdir in string ne at /usr/local/bin/portlint line 2038.
WARN: Makefile: unless this is a master port, PORTNAME has to be set by "=", not by "?=".
WARN: Makefile: unless this is a master port, PORTVERSION has to be set by "=", not by "?=".
Use of uninitialized value in split at /usr/local/bin/portlint line 2220.
FATAL: Makefile: CATEGORIES left blank. set it to "misc" if nothing seems apropriate.
WARN: Makefile: the port uses Java but is not part of the ``java'' category
Use of uninitialized value in string eq at /usr/local/bin/portlint line 2260.
Use of uninitialized value in string eq at /usr/local/bin/portlint line 2260.
Use of uninitialized value in string eq at /usr/local/bin/portlint line 2260.
Use of uninitialized value in string eq at /usr/local/bin/portlint line 2260.
Use of uninitialized value in string eq at /usr/local/bin/portlint line 2260.
Use of uninitialized value in string eq at /usr/local/bin/portlint line 2260.
Use of uninitialized value in string eq at /usr/local/bin/portlint line 2260.
Use of uninitialized value in string eq at /usr/local/bin/portlint line 2260.
Use of uninitialized value in string eq at /usr/local/bin/portlint line 2260.
Use of uninitialized value in string eq at /usr/local/bin/portlint line 2260.
Use of uninitialized value in string eq at /usr/local/bin/portlint line 2260.
Use of uninitialized value in string eq at /usr/local/bin/portlint line 2260.
Use of uninitialized value in string eq at /usr/local/bin/portlint line 2260.
Use of uninitialized value $makevar{"MASTER_SITES"} in string ne at /usr/local/bin/portlint line 2302.
Use of uninitialized value $portname in pattern match (m//) at /usr/local/bin/portlint line 2396.
Use of uninitialized value $portname in pattern match (m//) at /usr/local/bin/portlint line 2401.
Use of uninitialized value $portname in pattern match (m//) at /usr/local/bin/portlint line 2404.
Use of uninitialized value $portname in pattern match (m//) at /usr/local/bin/portlint line 2407.
Use of uninitialized value $portname in pattern match (m//) at /usr/local/bin/portlint line 2410.
Use of uninitialized value $portversion in string eq at /usr/local/bin/portlint line 2414.
Use of uninitialized value $distversion in string eq at /usr/local/bin/portlint line 2414.
FATAL: Makefile: either PORTVERSION or DISTVERSION must be specified
Use of uninitialized value $portversion in pattern match (m//) at /usr/local/bin/portlint line 2417.
Use of uninitialized value $portversion in pattern match (m//) at /usr/local/bin/portlint line 2417.
Use of uninitialized value in concatenation (.) or string at /usr/local/bin/portlint line 2469.
Use of uninitialized value $origin in substitution (s///) at /usr/local/bin/portlint line 2482, <VERSIONS> line 1.
Use of uninitialized value $origin in string eq at /usr/local/bin/portlint line 2486, <VERSIONS> line 1.
Use of uninitialized value in string eq at /usr/local/bin/portlint line 2486, <VERSIONS> line 1.
Use of uninitialized value $newversion in substitution (s///) at /usr/local/bin/portlint line 2491, <VERSIONS> line 1.
Use of uninitialized value $pkg_version in concatenation (.) or string at /usr/local/bin/portlint line 2494, <VERSIONS> line 1.
Use of uninitialized value $newversion in concatenation (.) or string at /usr/local/bin/portlint line 2494, <VERSIONS> line 1.
Syntax error: Unterminated quoted string
WARN: Makefile: unless this is a master port, COMMENT has to be set by "=", not by "?=".
WARN: Makefile: "PKGNAMEPREFIX" has to appear earlier.
WARN: Makefile: "PKGNAMESUFFIX" has to appear earlier.
Use of uninitialized value $i in string at /usr/local/bin/portlint line 299.
Use of uninitialized value $i in string eq at /usr/local/bin/portlint line 300.
Use of uninitialized value in string eq at /usr/local/bin/portlint line 300.
Use of uninitialized value $makevar{"DISTFILES"} in string eq at /usr/local/bin/portlint line 300.
2 fatal errors and 7 warnings found.

>Fix:


Patch attached with submission follows:

--- Makefile.orig	2010-03-13 11:46:20.000000000 +0200
+++ Makefile	2010-03-13 14:01:42.951729190 +0200
@@ -206,7 +206,7 @@
 #Workaround for gperf. #i85469#
 	@${LN} -sf ${LOCALBASE}/bin/gperf ${WRKSRC}/solenv/bin/gperf
 .if defined(WITH_KDE4)
-       @${LN} -sf ${LOCALBASE}/bin/moc-qt4 ${WRKSRC}/solenv/bin/moc
+	@${LN} -sf ${LOCALBASE}/bin/moc-qt4 ${WRKSRC}/solenv/bin/moc
 .endif
 
 do-build:


>Release-Note:
>Audit-Trail:
>Unformatted: