ports/147993: [patch] mail/dkim-milter -- plist problems

[Matthew Seaman]

>Number:         147993
>Category:       ports
>Synopsis:       [patch] mail/dkim-milter -- plist problems
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 19 09:40:01 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Matthew Seaman
>Release:        FreeBSD 8.1-PRERELEASE amd64
>Organization:
Infracaninophile
>Environment:
System: FreeBSD lucid-nonsense.infracaninophile.co.uk 8.1-PRERELEASE FreeBSD 8.1-PRERELEASE #4: Fri May 28 11:09:30 BST 2010 root at lucid-nonsense.infracaninophile.co.uk:/usr/obj/usr/src/sys/LUCID-NONSENSE amd64


	
>Description:


I'm getting a plist error for mail/dkim-milter with the following
options set in /etc/make.conf:

.if ${.CURDIR:M*/mail/dkim-milter}
WITH_LIBDKIM_INSTALL=   yes
WITH_LIBDKIM_SHARED=    yes
WITH_VERIFY_DOMAINKEYS= yes
WITH_STATS=             yes
WITH_DNS_UPGRADE=       yes
.endif

The error is this:

lucid-nonsense:~:% pkg_create -b dkim-milter-2.8.3_1
tar: lib/libar.a: Cannot stat: No such file or directory
tar: Error exit delayed from previous errors.
pkg_create: make_dist: tar command failed with code 256

ie. lib/libar appears in the plist, but it isn't installed by the port.

Defining WITHOUT_ARLIB=yes seemed to fix the problem -- given this
clue, after poring over the Makefile a bit, I think there's a logic
mistake: bld_USE_ARLIB is being removed from the site.cfg when
WITHOUT_ARLIB is *undefined* -- which implies that WITH_ARLIB is
defined.

This results in a correct plist with or without WITHOUT_ARLIB being
defined.

>How-To-Repeat:
	
>Fix:

	

--- dkim-milter.diff begins here ---
? work
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/mail/dkim-milter/Makefile,v
retrieving revision 1.64
diff -u -u -r1.64 Makefile
--- Makefile	28 Mar 2010 21:45:53 -0000	1.64
+++ Makefile	19 Jun 2010 09:19:23 -0000
@@ -209,7 +209,7 @@
 		-e '\|bld_USE_UNBOUND.*true|s/^dnl //g'
 .else
 SITE_SUB+=	-e 's|%%UNBOUND%%|dnl |g'
-.if !defined(WITHOUT_ARLIB)
+.if !defined(WITH_ARLIB)
 SITE_SUB+=	-e '\|bld_USE_ARLIB.*true|s/^dnl //g'
 .endif
 .endif
--- dkim-milter.diff ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: