ports/147655: [PATCH] textproc/libxslt: remove USE_GETTEXT=yes

[ports at c0decafe.net]

Helo,

On Thu, Jun 10, 2010 at 9:27 AM, Sunpoet Hsieh <sunpoet at sunpoet.net> wrote:
> On Thu, Jun 10, 2010 at 5:59 AM, ports at c0decafe.net <ports at c0decafe.net> wrote:
>> On Mon, 07 Jun 2010 23:51:51 +0800, Sunpoet Po-Chuan Hsieh wrote:
>>> gettext dependency was added to libxslt if CRYPTO option is on (by
>>> default). However, libxslt does not link against gettext library if
>>> libgpg-error was built without NLS support (WITHOUT_NLS option). Thus I
>>> think USE_GETTEXT should be removed.
>>>
>>> Dependency tree:
>>> libxslt ---> libgcrypt ---> libgpg-error ---> gettext
>>>      depends on                      (conditional)
>>
>> I'm not sure it is that simple.
>> Consider the following:
>> gmake[3]: Entering directory `/build/usr/ports/devel/eggdbus/work/
>> eggdbus-0.6/docs/man'
>> /usr/local/bin/xsltproc -nonet http://docbook.sourceforge.net/release/xsl/
>> current/manpages/docbook.xsl eggdbus-binding-tool.xml
>> /libexec/ld-elf.so.1: Shared object "libintl.so.8" not found, required by
>> "libgcrypt.so.16"

> For me, I build libgpg-error without gettext (WITHOUT_NLS=yes), thus
> my libxslt does not require gettext.

yes, but can WITHOUT_NLS guarantee that all dependencies are gettext safe?

If so, we could just make it actually respect WITHOUT_NLS:

--- Makefile.orig       2010-06-10 22:29:02.000000000 +0300
+++ Makefile    2010-06-10 22:31:57.000000000 +0300
@@ -46,7 +46,9 @@

 .if defined(WITH_CRYPTO)
 LIB_DEPENDS+=  gcrypt.16:${PORTSDIR}/security/libgcrypt
+.if !defined(WITHOUT_NLS)
 USE_GETTEXT=		yes
+.endif
 .else
 CONFIGURE_ARGS+=--without-crypto
 .endif

But i still see some serious breakages potential: race conditions, etc.

For the general use case, an implicit dependency might still be there.

Only USE_GETTEXT +bumps are safe for all the possible scenarios.

Just thoughts.