ports/147640: [PATCH] multimedia/mkvtoolnix: use += for setting CPPFLAGS and LDFLAGS

[Andriy Gapon]

>Number:         147640
>Category:       ports
>Synopsis:       [PATCH] multimedia/mkvtoolnix: use += for setting CPPFLAGS and LDFLAGS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 07 08:40:01 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Andriy Gapon
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
>Description:
Right now this port simply sets CPPFLAGS and LDFLAGS thus overriding any local
tuning that a user might want to do via e.g. /etc/make.conf.
I think that in general it is recommended that CPPFLAGS, LDFLAGS, etc are
amended, not overridden, in ports Makefiles.

Port maintainer (multimedia at FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:

--- mkvtoolnix-3.3.0_2.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/multimedia/mkvtoolnix.orig/Makefile /usr/ports/multimedia/mkvtoolnix/Makefile
--- /usr/ports/multimedia/mkvtoolnix.orig/Makefile	2010-06-06 23:43:58.000000000 +0300
+++ /usr/ports/multimedia/mkvtoolnix/Makefile	2010-06-07 11:33:29.069800315 +0300
@@ -28,8 +28,8 @@
 USE_GMAKE=	yes
 USE_ICONV=	yes
 GNU_CONFIGURE=	yes
-CPPFLAGS=	-I${LOCALBASE}/include
-LDFLAGS=	-L${LOCALBASE}/lib
+CPPFLAGS+=	-I${LOCALBASE}/include
+LDFLAGS+=	-L${LOCALBASE}/lib
 CONFIGURE_ENV=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}" \
 		ac_cv_path_PO4A=no
 CONFIGURE_ARGS=	--enable-lzo --enable-bz2 --disable-qt \
--- mkvtoolnix-3.3.0_2.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted: