ports/147571: install error in port textproc/iso8879 (with workaround)

[Hubert Tournier]

>Number:         147571
>Category:       ports
>Synopsis:       install error in port textproc/iso8879 (with workaround)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 06 20:30:06 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Hubert Tournier <hubert at frbsd.org>
>Release:        FreeBSD 8.0-RELEASE-p3 amd64
>Organization:
Chuck's corner <http://www.frbsd.org/fr/>
>Environment:
System: FreeBSD panthere 8.0-RELEASE-p3 FreeBSD 8.0-RELEASE-p3 #0: Sat Jun 5 13:50:13 CEST 2010 root at panthere:/usr/obj/usr/src/sys/NOYAU amd64

# head -10 /usr/ports/textproc/iso8879/Makefile
# New ports collection makefile for:	iso8879
# Date created:		June 19, 1997
# Whom:			jfieber
#
# $FreeBSD: ports/textproc/iso8879/Makefile,v 1.24 2010/06/03 21:18:10 pav Exp $
#

PORTNAME=	iso8879
PORTVERSION=	1986
PORTREVISION=	2
# pkg_info | grep -i unzip
unzip-6.0           List, test and extract compressed files in a ZIP archive


>Description:
Install error in port textproc/iso8879:
# cd /usr/ports/textproc/iso8879
# make install clean
===>  Installing for iso8879-1986_2
===>   iso8879-1986_2 depends on file: /usr/local/bin/xmlcatmgr - found
===>   Generating temporary packing list
===>  Checking if textproc/iso8879 already installed
Archive:  /usr/ports/distfiles/isoENTS.zip
caution: filename not matched:  -d
caution: filename not matched:  /usr/local/share/sgml/iso8879
*** Error code 11

Stop in /usr/ports/textproc/iso8879.

The -d directory option in unzip is not recognized.
The files contained in the archive are unzipped in a directory named "c" in the port directory.


>How-To-Repeat:
# cd /usr/ports/textproc/iso8879
# make install clean

>Fix:
More a workaround than a fix (this unzip -d problem could affect other ports):
# cd /usr/ports/textproc/iso8879
# diff -ruN Makefile Makefile.new
--- Makefile	2010-06-06 11:33:54.000000000 +0200
+++ Makefile.new	2010-06-06 11:26:16.000000000 +0200
@@ -34,7 +34,10 @@
 	@[ -d ${INSTDIR} ] || ${MKDIR} ${INSTDIR}
 
 do-install:
-	@${UNZIP_CMD} ${EXTRACT_BEFORE_ARGS} ${DISTDIR}/${DISTFILES} -d ${INSTDIR}
+	@CURDIR=`pwd`
+	@cd ${INSTDIR}
+	@${UNZIP_CMD} ${EXTRACT_BEFORE_ARGS} ${DISTDIR}/${DISTFILES}
+	@cd ${CURDIR}
 	@${INSTALL_DATA} ${FILESDIR}/catalog ${INSTDIR}/catalog
 	@${CHMOD} ${SHAREMODE} ${INSTDIR}/*
 	@${CHOWN} -R ${SHAREOWN}:${SHAREGRP} ${INSTDIR}
# cp Makefile.new Makefile
# make install clean
===>  Installing for iso8879-1986_2
===>   iso8879-1986_2 depends on file: /usr/local/bin/xmlcatmgr - found
===>   Generating temporary packing list
===>  Checking if textproc/iso8879 already installed
Archive:  /usr/ports/distfiles/isoENTS.zip
  inflating: c/ISOamsa               
  inflating: c/ISOamsb               
  inflating: c/ISOamsc               
  inflating: c/ISOamsn               
  inflating: c/ISOamso               
  inflating: c/ISOamsr               
  inflating: c/ISObox                
  inflating: c/ISOcyr1               
  inflating: c/ISOcyr2               
  inflating: c/ISOdia                
  inflating: c/ISOgrk1               
  inflating: c/ISOgrk2               
  inflating: c/ISOgrk3               
  inflating: c/ISOgrk4               
  inflating: c/ISOlat1               
  inflating: c/ISOlat2               
  inflating: c/ISOnum                
  inflating: c/ISOpub                
  inflating: c/ISOtech               
===>   Registering installation for iso8879-1986_2
===>  Cleaning for iso8879-1986_2

>Release-Note:
>Audit-Trail:
>Unformatted: