ports/147311: emulators/snes9x-gtk does not recognize --with(out)-screenshot

[Demelier David]

>Number:         147311
>Category:       ports
>Synopsis:       emulators/snes9x-gtk does not recognize --with(out)-screenshot
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 02 08:10:01 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Demelier David
>Release:        8.1-PRERELEASE
>Organization:
>Environment:
FreeBSD Melon.malikania.fr 8.1-PRERELEASE FreeBSD 8.1-PRERELEASE #1: Mon May 31 23:06:01 CEST 2010     root at Melon.malikania.fr:/usr/obj/usr/src/sys/Melon  amd64

>Description:
The emulators/snes9x-gtk configure script does not recognize --with(out)-screenshot option. Maybe the snes9x-gtk developers didn't remove this option and it's enabled by default (if libpng is found)

Because snes9x-gtk need libpng, screenshot feature will be enabled in any case. I propose the complete removal of the SCREENSHOT option.
>How-To-Repeat:
cd /usr/ports/emulators/snes9x-gtk
make config
# uncheck screenshot

make configure

make config
# check screenshot

make configure 

see : configure: WARNING: unrecognized options: --with-screenshot
see : configure: WARNING: unrecognized options: --without-screenshot

>Fix:
--- Makefile.orig	2010-06-02 09:40:26.000000000 +0200
+++ Makefile	2010-06-02 09:57:11.000000000 +0200
@@ -33,7 +33,6 @@
 
 OPTIONS=	DEBUG	"Enable debug information"	off \
 		OPENGL	"Enable OpenGL support"	off \
-		SCREENSHOT	"Enable screenshot support"	on \
 		X86_ASM	"Use i386 optimization (only for i386)"	on \
 		MMX	"Enable MMX (only for i386)"	off \
 		JMA	"Enable JMA archive decompression support"	on \
@@ -71,13 +70,6 @@
 CONFIGURE_ARGS+=	--without-opengl
 .endif
 
-.if !defined(WITHOUT_SCREENSHOT)
-LIB_DEPENDS+=	png.6:${PORTSDIR}/graphics/png
-CONFIGURE_ARGS+=	--with-screenshot
-.else
-CONFIGURE_ARGS+=	--without-screenshot
-.endif
-
 .if !defined(WITHOUT_JMA)
 CONFIGURE_ARGS+=	--with-jma-decomp
 .else


>Release-Note:
>Audit-Trail:
>Unformatted: