ports/148773: [PATCH] graphics/aaphoto: update to 0.38

Horvath Andras han at log69.com
Tue Jul 20 10:32:32 UTC 2010


Thanks for the test.

I think the patch should be good then. Will you commit it if noone else
has problem with it?

Andras


On Tue, 20 Jul 2010 10:38:01 +0200
Philippe Audéoud <jadawin at FreeBSD.org> wrote:

> On Tue, 20 Jul 2010, Horvath Andras wrote:
> 
> > Hi,
> > 
> > As i see, you tested it on amd64, which i also tested it on.
> > 
> > I'd like to ask for help to test it on a sparc or ppc system to
> > compile. It is supposed to compile without the OpenMP option
> > switches.
> > 
> > AFAIK the sparc platform has only GCC v3, and therefore it doesn't
> > have support for OpenMP. Just like with OS under 7.0 before GCC 4.2.
> > 
> > I agree with you, it may be better that way to test if it's not
> > i386 or amd64 platform, then it should compile without openmp. The
> > only case it should compile with openmp if OS is above 7.0 and the
> > arch is whether amd64 or i386.
> > 
> [...]
> 
> Please, have a look here:
> http://paste.openbsd-france.org/?show=mbd94c80
> 
> 
> > I attached another patch. Important part is:
> > 
> > -.if ${ARCH} != "amd64" && ${ARCH} != "i386"
> > -BROKEN=                Does not compile on !amd64 and !i386
> > -.endif
> > -
> > -.if ${OSVERSION} >= 700000
> > +.if ${ARCH} == "amd64" || ${ARCH} == "i386" && ${OSVERSION} >=
> > 700000 CFLAGS+=       -fopenmp -D__OPENMP__
> >  .endif
> > 
> > 
> > If somebody could be kind to test it on a sparc, ia64 or pcc system.
> > 
> > Thanks.
> > 
> > 
> > On Tue, 20 Jul 2010 09:34:07 +0200
> > Philippe Audéoud <jadawin at FreeBSD.org> wrote:
> > 
> > > On Tue, 20 Jul 2010, Horvath Andras wrote:
> > > 
> > > > Could anybody help me test the port with the patch to compile
> > > > on a tier-2 hardware and confirm that it works?
> > > > 
> > > > 
> > > > On Tue, 20 Jul 2010 06:53:22 GMT
> > > > jadawin at FreeBSD.org wrote:
> > > > 
> > > > > Synopsis: [PATCH] graphics/aaphoto: update to 0.38
> > > > > 
> > > > > Responsible-Changed-From-To: freebsd-ports-bugs->jadawin
> > > > > Responsible-Changed-By: jadawin
> > > > > Responsible-Changed-When: Tue Jul 20 06:53:22 UTC 2010
> > > > > Responsible-Changed-Why: 
> > > > > I'll take it.
> > > > > 
> > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=148773
> > > > _______________________________________________
> > > > freebsd-ports-bugs at freebsd.org mailing list
> > > > http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
> > > > To unsubscribe, send any mail to
> > > > "freebsd-ports-bugs-unsubscribe at freebsd.org"
> > > 
> > > 
> > > Hello,
> > > 
> > > I tested it on my tinderbox:
> > > 
> > > [...]
> > > cd .
> > > && /bin/sh /work/a/ports/graphics/aaphoto/work/aaphoto-0.38/missing
> > > --run autoheader autoheader: not found
> > > WARNING: `autoheader' is missing on your system.  You should only
> > > need it if
> > >          you modified `acconfig.h' or `configure.ac'.  You might
> > > want to install the `Autoconf' and `GNU m4' packages.  Grab them
> > >          from any GNU archive site.
> > > [...]
> > > 
> > > from http://a.tchoum.info/tb/logs/7.1-FreeBSD/aaphoto-0.38.log
> > > 
> > > btw i don't really understand why 
> > > 
> > > -.if ${ARCH} != "amd64" && ${ARCH} != "i386"
> > > -BROKEN=         Does not compile on !amd64 and !i386
> > > -.endif
> > > -
> > > -.if ${OSVERSION} >= 700000
> > > +.if ${OSVERSION} >= 700000 && \
> > > +        ${ARCH} != "ia64" && \
> > > +        ${ARCH} != "powerpc" && \
> > > +        ${ARCH} != "powerpc64" && \
> > > +        ${ARCH} != "sparc64"
> > > 
> > > is better. if ${ARCH} != "amd64" && ${ARCH} != "i386" is enough to
> > > test arch.
> > > 
> > > Regards,
> > > 
> > _______________________________________________
> > freebsd-ports-bugs at freebsd.org mailing list
> > http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
> > To unsubscribe, send any mail to
> > "freebsd-ports-bugs-unsubscribe at freebsd.org"
> 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch.txt
URL: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/attachments/20100720/3dd45c37/attachment.txt>


More information about the freebsd-ports-bugs mailing list