ports/148774: x11/nvidia-driver: Being possible to get compiled on Tinderbox

[Leinier Cruz Salfran]

>Number:         148774
>Category:       ports
>Synopsis:       x11/nvidia-driver: Being possible to get compiled on Tinderbox
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 19 20:30:03 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Leinier Cruz Salfran
>Release:        8.0-RELEASE-p2
>Organization:
IPI 'Jose M. Maceo Grajales'
>Environment:
FreeBSD 8.0-RELEASE-p2 #0: Mon Jul 19 14:06:21 CDT 2010    root at tinderbox.ipigto.rimed.cu:/usr/src/sys/magic/kernel/path
>Description:
i can't construct the 'x11/nvidia-driver' package on tinderbox because the port creator require an X server implementation installed but there is no 'xorg-server' installed initially on tinderbox so the package can't be constructed

i examined the result of '/usr/sbin/pkg_info -qO x11-servers/xorg-server' and '/usr/sbin/pkg_info -qO graphics/libGL' and saw that it's the same result of '/usr/bin/make -C /usr/ports/x11-servers/xorg-server -V PKGNAME' and '/usr/bin/make -C /usr/ports/graphics/libGL -V PKGNAME' so i modified the 'Makefile' file in order to add a 'Tinderbox hack' but keeping the original port code to avoid author conflicts

i can construct 'x11/nvidia-driver*' packages successfully now with 'WITH_TINDERBOX_HACK=yes' and 'FORCE_PACKAGE=yes' environment variables on Tinderbox

i attached the unified patch and hope the patch will be applied
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- Makefile.orig	2010-07-19 15:52:08.000000000 -0400
+++ Makefile	2010-07-19 16:10:37.000000000 -0400
@@ -18,6 +18,7 @@
 COMMENT=	NVidia graphics card binary drivers for hardware OpenGL rendering
 
 NO_PACKAGE=	should be recompiled for a particular FreeBSD kernel
+USE_XORG=	xorg-server
 USE_GL=		gl
 USE_LDCONFIG=	yes
 SUB_FILES+=	pkg-message
@@ -48,7 +49,8 @@
 ONLY_FOR_ARCHS=	i386
 .endif
 
-OPTIONS=	FREEBSD_AGP	"Use FreeBSD AGP GART driver" off \
+OPTIONS=	TINDERBOX_HACK	"Use Tinderbox hack" off \
+		FREEBSD_AGP	"Use FreeBSD AGP GART driver" off \
 		ACPI_PM		"Enable support for ACPI Power Management" off \
 		LINUX		"Build with support for Linux compatibility" on
 .if ${NVVERSION} >= 1952200
@@ -57,13 +59,18 @@
 
 .include <bsd.port.pre.mk>
 
+.if defined(WITH_TINDERBOX_HACK)
+XSERVVERSION!=	${MAKE} -C ${PORTSDIR}/x11-servers/xorg-server -V PKGNAME 2>/dev/null || true
+LIBGLVERSION!=	${MAKE} -C ${PORTSDIR}/graphics/libGL -V PKGNAME 2>/dev/null || true
+.endif
+.if defined(WITHOUT_TINDERBOX_HACK)
 # XXX Should use ${PKG_INFO} but it does not expand for some reason XXX
 #
-XSERVVERSION!=	/usr/sbin/pkg_info -qO x11-servers/xorg-server 2>/dev/null || true
-LIBGLVERSION!=	/usr/sbin/pkg_info -qO graphics/libGL 2>/dev/null || true
-
+XSERVVERSION!=  /usr/sbin/pkg_info -qO x11-servers/xorg-server 2>/dev/null || true
+LIBGLVERSION!=  /usr/sbin/pkg_info -qO graphics/libGL 2>/dev/null || true
 .if empty(XSERVVERSION)
-IGNORE=		needs an X server implementation installed
+IGNORE=         needs an X server implementation installed
+.endif
 .endif
 
 PLIST_SUB+=	XSERVVERSION=${XSERVVERSION} LIBGLVERSION=${LIBGLVERSION} \


>Release-Note:
>Audit-Trail:
>Unformatted: