ports/148607: [patch] graphics/zathura: respect STRIP, make build verbose by default

Anonymous swell.k at gmail.com
Wed Jul 14 22:00:15 UTC 2010


>Number:         148607
>Category:       ports
>Synopsis:       [patch] graphics/zathura: respect STRIP, make build verbose by default
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jul 14 22:00:13 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Anonymous
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
>Description:
- drop USE_GMAKE (adapt include config.mk and $(shell...))
- respect DEBUG_FLAGS rather than DFLAGS, currently any flag (e.g. `-ggdb3')
  in DEBUG_FLAGS or CFLAGS is being overriden by DFLAGS' `-g'
- use PTHREAD_LIBS instead of -lpthread
- no need to specify -lc when no -nostdlib is used
- make build target verbose, options target doesn't show what flags are used when linking
- make install target verbose, so the user know what's being installed
- use CFLAGS when linking, too; makes things like -flto in CFLAGS work
- add extra tab to MAN1 (cosmetic)
>How-To-Repeat:
>Fix:
--- a.diff begins here ---
Index: graphics/zathura/Makefile
===================================================================
RCS file: /a/.cvsup/ports/graphics/zathura/Makefile,v
retrieving revision 1.1
diff -u -p -r1.1 Makefile
--- graphics/zathura/Makefile	5 Jul 2010 17:36:12 -0000	1.1
+++ graphics/zathura/Makefile	14 Jul 2010 21:46:19 -0000
@@ -16,13 +16,28 @@ COMMENT=	Customizable lightweight pdf vi
 LIB_DEPENDS=	poppler-glib.4:${PORTSDIR}/graphics/poppler-gtk	\
 		cairo.2:${PORTSDIR}/graphics/cairo
 
-USE_GMAKE=	yes
 USE_GNOME=	glib20 gtk20
-MAN1=	zathura.1
+
+MAN1=		zathura.1
 MANCOMPRESSED=	no
 PLIST_FILES=	bin/zathura
 
-post-patch:
-	@${REINPLACE_CMD} -e 's|man1|man/man1|g' ${WRKSRC}/Makefile
+post-patch:	.SILENT
+	${REINPLACE_CMD} -e 's|man1|man/man1|g' \
+		-e '/CC/s/-s[[:space:]]/${STRIP} /' \
+		-e '/CFLAGS/!s/$${LDFLAGS}/$${CFLAGS} &/' \
+		-e 's/{DFLAGS/{DEBUG_FLAGS/g' \
+		-e 's/755/${BINMODE}/' \
+		-e 's/644/${MANMODE}/' \
+		-e '/echo[[:space:]]CC/d' \
+		-e '/echo/!s/@//' \
+		-e '/^all:/s/options//' \
+		-e 's/\(include\)[[:space:]]\(.*\)/.\1 "\2"/' \
+		${WRKSRC}/Makefile
+	${REINPLACE_CMD} -e 's|/usr/include|${LOCALBASE}/include|' \
+		-e 's/-lpthread/${PTHREAD_LIBS}/' \
+		-e 's/-lc//' \
+		-e 's/$$(shell[[:space:]]\(.*\))/`\1`/' \
+		${WRKSRC}/config.mk
 
 .include <bsd.port.mk>
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:



More information about the freebsd-ports-bugs mailing list