ports/148329: shells/bash broken requires libiconv

[Garrett Wollman]

>Number:         148329
>Category:       ports
>Synopsis:       shells/bash broken requires libiconv
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 02 19:20:03 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Garrett Wollman
>Release:        FreeBSD 7.3-RELEASE i386
>Organization:
MIT Computer Science & Artificial Intelligence Lab
>Environment:
FreeBSD ca.csail.mit.edu 7.3-RELEASE FreeBSD 7.3-RELEASE #5: Fri Apr 30 16:18:18 EDT 2010     root at ca.csail.mit.edu:/usr/obj/usr/src/sys/CSAIL  i386



>Description:

shells/bash has an unhandled dependency on libiconv.

>How-To-Repeat:
Attempt to build shells/bash on a machine with no libiconv.  Watch it
fail:

[root at ca /usr/ports/shells/bash]# make
===>  Building for bash-4.1.7
rm -f bash
cc -L./builtins -L./lib/readline -L./lib/readline -L./lib/glob  -L./lib/tilde  -L./lib/sh -L/usr/local/lib  -rdynamic  -O -pipe -o bash shell.o eval.o y.tab.o general.o make_cmd.o print_cmd.o   dispose_cmd.o execute_cmd.o variables.o copy_cmd.o error.o  expr.o flags.o jobs.o subst.o hashcmd.o hashlib.o mailcheck.o  trap.o input.o unwind_prot.o pathexp.o sig.o test.o version.o  alias.o array.o arrayfunc.o assoc.o braces.o bracecomp.o bashhist.o  bashline.o  list.o stringlib.o locale.o findcmd.o redir.o  pcomplete.o pcomplib.o syntax.o xmalloc.o  -lbuiltins -lglob -lsh -lreadline -lhistory -ltermcap  -ltilde   -liconv 
/usr/bin/ld: cannot find -liconv
*** Error code 1

>Fix:

Make shells/bash depend on converters/libiconv, or else fix the broken
vendor makefile to not link against libiconv when configure doesn't
find it.  It builds just fine without it.

>Release-Note:
>Audit-Trail:
>Unformatted: