ports/143057: Ganglia WEB frontend can't find rrdtool

[Jason Bacon]

>Number:         143057
>Category:       ports
>Synopsis:       Ganglia WEB frontend can't find rrdtool
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 21 15:50:04 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Jason Bacon
>Release:        8.0-RELEASE
>Organization:
University of Wisconsin - Milwaukee
>Environment:
FreeBSD sculpin.jbacon.dyndns.org 8.0-RELEASE FreeBSD 8.0-RELEASE #0: Sat Nov 21 15:48:17 UTC 2009     root at almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386

>Description:

The ganglia-webfrontend installation includes a file called conf.php that sets parameters for the WEB display.  This file sets a variable RRDTOOL to /usr/bin/rrdtool, which is incorrect.  It should be ${LOCALBASE}/bin/rrdtool.  As a result, many features of the ganglia web interface don't work out of the box.

The original port Makefile patches conf.php in ${WRKSRC} with a ${REINPLACE} in post-patch, but the configure script that runs next recreates conf.php,so the patched version is lost.

This update simply moves the ${REINPLACE} to the build phase, after configure has regenerated conf.php.

>How-To-Repeat:
Install the ganglia-webfrontend and ganglia-monitor-core ports, edit their configuration files, and configure apache as directed.
>Fix:
Unified diff attached.


Patch attached with submission follows:

--- Makefile.orig	2010-01-21 08:51:46.000000000 -0600
+++ Makefile	2010-01-21 08:58:14.000000000 -0600
@@ -63,15 +63,14 @@
 	     ${ECHO_MSG} '-------------------------------------------------------------------------')
 .endif
 
-post-patch:
-	@ ${REINPLACE_CMD} -e "s|%%LOCALBASE%%|${LOCALBASE}|g" ${WRKSRC}/conf.php
-
 do-build:
 	@${MKDIR} -m 0755 ${TMP_WEBFRONTDIR}
 	@cd ${WRKSRC} && ${FIND} * \( -name conf.php\* \
 	    ${EXCEPTFILES:S/^/-o -name /} -o -name \*.orig \) \
 	    -a -prune -o -print \
 	    | ${TAR} cTf - - | ${TAR} xUCf ${TMP_WEBFRONTDIR} -
+	@${REINPLACE_CMD} -e "s|/usr/bin/rrdtool|${LOCALBASE}/bin/rrdtool|g" \
+	    ${WRKSRC}/conf.php
 	@${CP} ${WRKSRC}/conf.php ${TMP_WEBFRONTDIR}/conf.php.sample
 
 do-install:


>Release-Note:
>Audit-Trail:
>Unformatted: