ports/143016: mail/p5-Mail-SpamAssassin: portlint complains

[TAOKA Fumiyoshi]

>Number:         143016
>Category:       ports
>Synopsis:       mail/p5-Mail-SpamAssassin: portlint complains
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 20 13:40:08 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     TAOKA Fumiyoshi
>Release:        
>Organization:
>Environment:
>Description:
Portlint pointed out 2 fatal errors.
Here is a fix which was originally submitted by 
Takefu <takefu at airport.fm> for ports/141776.

>How-To-Repeat:

# portlint
FATAL: Makefile: [212]: contiguous blank lines (> 1 lines) found.
FATAL: Makefile: [74]: USE_OPENSSL is set after including bsd.port.pre.mk.
WARN: Makefile: possible use of absolute pathname "/var/db/spamassassin".
WARN: Makefile: possible use of absolute pathname "/var/spool/spamd".
WARN: Makefile: "RUN_DEPENDS" has to appear earlier.
WARN: Makefile: do not set RUN_DEPENDS to ${BUILD_DEPENDS}. Instead, explicity list out required RUN_DEPENDS dependencies.
WARN: Makefile: wrong dependency value for RUN_DEPENDS. RUN_DEPENDS requires 2 or 3 colon-separated tuples.
2 fatal errors and 5 warnings found.

>Fix:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/mail/p5-Mail-SpamAssassin/Makefile,v
retrieving revision 1.126
diff -u -r1.126 Makefile
--- Makefile	22 Jul 2009 16:26:48 -0000	1.126
+++ Makefile	20 Jan 2010 13:22:51 -0000
@@ -53,6 +53,10 @@
 		SPF_QUERY "Add SPF query support" off \
 		RELAY_COUNTRY "Relay country support" off
 
+.if !defined(WITHOUT_SSL)
+USE_OPENSSL=	yes
+.endif
+
 .include <bsd.port.pre.mk>
 
 .if defined (WITH_SPAMC)
@@ -71,7 +75,6 @@
 .if !defined(WITHOUT_SSL)
 .include "${PORTSDIR}/Mk/bsd.openssl.mk"
 RUN_DEPENDS+=	${SITE_PERL}/IO/Socket/SSL.pm:${PORTSDIR}/security/p5-IO-Socket-SSL
-USE_OPENSSL=	yes
 CFLAGS+=	-I${OPENSSLINC}
 LDFLAGS+=	-L${OPENSSLLIB}
 CONFIGURE_ARGS+=	ENABLE_SSL=yes
@@ -210,7 +213,6 @@
 	@${REINPLACE_CMD} -e '/^CC =/d; \
 		s|@SSLCFLAGS@|& $${CFLAGS}|g' ${WRKSRC}/spamc/Makefile.in
 
-
 .if defined(WITH_RAZOR)
 	${REINPLACE_CMD} -e '/Razor2/s/^#loadplugin/loadplugin/' ${WRKSRC}/rules/v312.pre
 .endif

>Release-Note:
>Audit-Trail:
>Unformatted: