ports/142843: [patch] port editors/openoffice.org-3 fails to build on 9.0-Current

[Andrey Kosachenko]

>Number:         142843
>Category:       ports
>Synopsis:       [patch] port editors/openoffice.org-3 fails to build on 9.0-Current
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 14 23:40:00 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Andrey Kosachenko
>Release:        9.0-Current
>Organization:
>Environment:
FreeBSD rock.intra 9.0-CURRENT FreeBSD 9.0-CURRENT #0: Sun Jan  3 17:03:30 UTC 2010     root at rock.intra:/usr/obj/usr/src/sys/ROCK-SMP-ULE-20100103  amd64
>Description:
port editors/openoffice.org-3 fails to build on FreeBSD 9.0-Current systems.

Deeper investigation shown the reason: unzip from base system is used with unsupported options combination whereas usage of uznip from archivers/uznip is expected. I.e:

[root at rock][/usr/ports/editors/openoffice.org-3/work/OOO310_m19]source FreeBSDAMDEnv.Set
[root at rock][/usr/ports/editors/openoffice.org-3/work/OOO310_m19]cd odk/
[root at rock][/usr/ports/editors/openoffice.org-3/work/OOO310_m19/odk]build --from odk
...
/usr/ports/editors/openoffice.org-3/work/OOO310_m19/odk/pack/gendocu
mkdir -p ../../unxfbsdx.pro/misc/java_src/
/usr/local/bin/gcp /usr/ports/editors/openoffice.org-3/work/OOO310_m19/solver/310/unxfbsdx.pro/bin/juh_src.zip ../../unxfbsdx.pro/misc/java_src/juh_src.zip
cd ../../unxfbsdx.pro/misc/java_src && unzip -quo juh_src.zip
unzip: -n, -o and -u are contradictory
dmake:  Error code 1, while making '../../unxfbsdx.pro/misc/java_src/juh_src.zip'
dmake:  '../../unxfbsdx.pro/misc/java_src/juh_src.zip' removed.

ERROR: Error 65280 occurred while making /usr/ports/editors/openoffice.org-3/work/OOO310_m19/odk/pack/gendocu
rmdir /tmp/62023

according to 'man 1 unzip' (section HISTORY)  starting from FreeBSD 8.0 unzip appeared in the base system. Though not tested, but it is possible that issue is reproducible on 8.X as well.
>How-To-Repeat:
sudo make -C /usr/ports/editors/openoffice.org-3 build

.. <skipped> ...

1 module(s):
        odk
need(s) to be rebuilt

Reason(s):

ERROR: error 65280 occurred while making /usr/ports/editors/openoffice.org-3/work/OOO310_m19/odk/pack/gendocu

Attention: if you build and deliver the above module(s) you may prolongue your the build issuing command "build --from odk"

rmdir /tmp/21398
*** Error code 1

Stop in /usr/ports/editors/openoffice.org-3.
>Fix:
There is a simple patch which is supposed to fix the issue.

Patch attached with submission follows:

# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#	Makefile.patch
#
echo x - Makefile.patch
sed 's/^X//' >Makefile.patch << '510beb51362fa3774a3169b33b47ec43'
X--- Makefile.orig	2010-01-14 21:52:41.000000000 +0000
X+++ Makefile	2010-01-14 23:10:13.000000000 +0000
X@@ -106,7 +106,7 @@
X 		PATH=${WRKSRC}/solenv/bin:$$PATH
X 
X BUILD_DEPENDS+=	zip:${PORTSDIR}/archivers/zip \
X-		unzip:${PORTSDIR}/archivers/unzip \
X+		${LOCALBASE}/bin/unzip:${PORTSDIR}/archivers/unzip \
X 		gcp:${PORTSDIR}/sysutils/coreutils \
X 		gpatch:${PORTSDIR}/devel/patch \
X 		${SITE_PERL}/Archive/Zip.pm:${PORTSDIR}/archivers/p5-Archive-Zip \
X@@ -196,6 +196,7 @@
X pre-configure:
X #Workaround for gperf. #i85469#
X 	@${LN} -sf ${LOCALBASE}/bin/gperf ${WRKSRC}/solenv/bin/gperf
X+	@${LN} -sf ${LOCALBASE}/bin/unzip ${WRKSRC}/solenv/bin/unzip
X 
X do-build:
X 	@cd ${WRKSRC} ; ./bootstrap
510beb51362fa3774a3169b33b47ec43
exit



>Release-Note:
>Audit-Trail:
>Unformatted: