ports/142454: [patch] sysutils/fusefs-curlftpfs core dump on permission denied

[Aragon Gouveia]

>Number:         142454
>Category:       ports
>Synopsis:       [patch] sysutils/fusefs-curlftpfs core dump on permission denied
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 08 01:20:09 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Aragon Gouveia
>Release:        8.0-STABLE
>Organization:
>Environment:
FreeBSD fuzz.geek.sh 8.0-STABLE FreeBSD 8.0-STABLE #2: Sat Dec  5 11:43:56 SAST 2009     toor at fuzz.geek.sh:/usr/obj/usr/src/sys/FUZZ  amd64

>Description:
There is a bug with curlftpfs which causes it to core dump when an FTP server rejects a file retrieval operation with permission denied.  It is reported upstream here:

http://code.google.com/p/curlftpfs/issues/detail?id=2

I've updated that report with a patch which fixes it for me.  Please could you consider integrating the patch into our port until upstream creates a new release with the fix.

Patch attached.

Thanks.

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- ftpfs.c.orig	2008-04-30 01:05:47.000000000 +0200
+++ ftpfs.c	2010-01-08 03:04:05.000000000 +0200
@@ -611,10 +611,12 @@ static void free_ftpfs_file(struct ftpfs
     curl_easy_cleanup(fh->write_conn);
   g_free(fh->full_path);
   g_free(fh->open_path);
-  sem_destroy(&fh->data_avail);
-  sem_destroy(&fh->data_need);
-  sem_destroy(&fh->data_written);
-  sem_destroy(&fh->ready);
+  if (fh->data_avail) {
+    sem_destroy(&fh->data_avail);
+    sem_destroy(&fh->data_need);
+    sem_destroy(&fh->data_written);
+    sem_destroy(&fh->ready);
+  }
   free(fh);
 }
 


>Release-Note:
>Audit-Trail:
>Unformatted: