ports/142446: [patch] devel/bugzilla use $SUB_FILES & $SUB_LIST to dynamically adjust pkg-message

[Sevan Janiyan]

>Number:         142446
>Category:       ports
>Synopsis:       [patch] devel/bugzilla  use $SUB_FILES & $SUB_LIST to dynamically adjust pkg-message
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 07 23:30:04 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Sevan Janiyan
>Release:        
>Organization:
>Environment:
>Description:

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/devel/bugzilla/Makefile,v
retrieving revision 1.68
diff -u -r1.68 Makefile
--- Makefile	24 Nov 2009 21:44:41 -0000	1.68
+++ Makefile	7 Jan 2010 23:17:20 -0000
@@ -67,6 +67,8 @@
 PLIST_SUB+=	BUGZILLADIR=${BUGZILLADIR:S!^${PREFIX}/!!}
 
 DATA_DIRS_LIST=	images js skins
+SUB_FILES=	pkg-message
+SUB_LIST=	BUGZILLADIR=${BUGZILLADIR}
 
 .include <bsd.port.pre.mk>
 
@@ -163,10 +165,6 @@
 	@${FIND} ${WRKSRC}/docs -type f | \
 		${XARGS} ${REINPLACE_CMD} -i '' -e "s!/var/www/html/bugzilla!${BUGZILLADIR}!"
 
-do-build:
-	@${SED} -e "s:%%BUGZILLADIR%%:${BUGZILLADIR}:g; s:%%DOCSDIR%%:${DOCSDIR}:g" \
-		${MASTERDIR}/pkg-message >${PKGMESSAGE}
-
 do-install:
 	${MKDIR} ${BUGZILLADIR}
 	${FIND} ${WRKSRC} \! -type d -maxdepth 1 \! -name "UPGRADING*" -exec \
Index: pkg-message
===================================================================
RCS file: pkg-message
diff -N pkg-message
--- pkg-message	1 Dec 2008 15:38:51 -0000	1.11
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,33 +0,0 @@
-==========================================================================
-  Bugzilla has now been installed.  To quick setup you have to:
-
-  1. Create database user who has rights on bugs database manipulation
-     by following mysql commands (for MySQL 4.0 or later):
-
-     GRANT SELECT, INSERT, UPDATE, DELETE, INDEX, ALTER, CREATE, LOCK TABLES,
-           CREATE TEMPORARY TABLES, DROP, REFERENCES 
-	   ON <database>.* TO <dbuser>@<host> 
-	   IDENTIFIED BY '<password>';
-     FLUSH PRIVILEGES;
-
-     where <database> is a bugs database name; <dbuser> is a bugs database
-           owner; <host> is a host there bugzilla is being setup;
-           <password> is a database owner's password;
-
-  2. Change working directory to %%BUGZILLADIR%%
-  3. Run "./checksetup.pl" script as root user
-  4. Read output carefully and follow all instructions
-
-  For more complete database setup and post-installation instructions
-  and security tips/notes please read "Bugzilla Guide" in
-  %%DOCSDIR%%/en/html/ (chapter 2: "Installing Bugzilla")
-==========================================================================
-
-For upgrades:
-  0. Back up your data.
-  1. Run "./checksetup.pl" inside %%BUGZILLADIR%%.  You may need to
-     run it several times.
-  2. Restart your Web server, especially if you're using mod_perl: this
-     will save you from a number of troubles.
-
-==========================================================================
Index: files/pkg-message.in
===================================================================
RCS file: files/pkg-message.in
diff -N files/pkg-message.in
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/pkg-message.in	7 Jan 2010 23:17:21 -0000
@@ -0,0 +1,33 @@
+==========================================================================
+  Bugzilla has now been installed.  To quick setup you have to:
+
+  1. Create database user who has rights on bugs database manipulation
+     by following mysql commands (for MySQL 4.0 or later):
+
+     GRANT SELECT, INSERT, UPDATE, DELETE, INDEX, ALTER, CREATE, LOCK TABLES,
+           CREATE TEMPORARY TABLES, DROP, REFERENCES 
+	   ON <database>.* TO <dbuser>@<host> 
+	   IDENTIFIED BY '<password>';
+     FLUSH PRIVILEGES;
+
+     where <database> is a bugs database name; <dbuser> is a bugs database
+           owner; <host> is a host there bugzilla is being setup;
+           <password> is a database owner's password;
+
+  2. Change working directory to %%BUGZILLADIR%%
+  3. Run "./checksetup.pl" script as root user
+  4. Read output carefully and follow all instructions
+
+  For more complete database setup and post-installation instructions
+  and security tips/notes please read "Bugzilla Guide" in
+  %%DOCSDIR%%/en/html/ (chapter 2: "Installing Bugzilla")
+==========================================================================
+
+For upgrades:
+  0. Back up your data.
+  1. Run "./checksetup.pl" inside %%BUGZILLADIR%%.  You may need to
+     run it several times.
+  2. Restart your Web server, especially if you're using mod_perl: this
+     will save you from a number of troubles.
+
+==========================================================================


>Release-Note:
>Audit-Trail:
>Unformatted: